Skip to content
This repository was archived by the owner on Jan 4, 2019. It is now read-only.

Use callback dialog methods in RunFileChooser #241

Merged
merged 6 commits into from
Jul 6, 2017
Merged

Use callback dialog methods in RunFileChooser #241

merged 6 commits into from
Jul 6, 2017

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Jul 5, 2017

@darkdh darkdh self-assigned this Jul 5, 2017
@darkdh darkdh requested review from bridiver, bbondy and bsclifton July 5, 2017 21:05
@darkdh darkdh mentioned this pull request Jul 5, 2017
Closed
@bridiver
Copy link
Collaborator

bridiver commented Jul 5, 2017

this works for now, but we should dump these in favor of ui::SelectFileDialog

@bridiver
Copy link
Collaborator

bridiver commented Jul 5, 2017

please set label/milestone

@darkdh darkdh added this to the 4.2.7 milestone Jul 5, 2017
@darkdh darkdh mentioned this pull request Jul 5, 2017
Closed
@bridiver bridiver merged commit b48a08a into master Jul 6, 2017
@bsclifton bsclifton deleted the web_dialog_helper branch September 19, 2017 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bridiver bridiver bridiver approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@darkdh darkdh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facebook Messenger Error -- Cannot Send Image/File
3 participants
@darkdh @bridiver @kevinsawicki