This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Import password from Chrome/Canary/Chromium #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
force-pushed
the
import-pwd-chrome
branch
3 times, most recently
from
6d5e908 to
fa9ac30
Compare
darkdh
changed the title
darkdh
force-pushed
the
import-pwd-chrome
branch
from
fa9ac30 to
a424588
Compare
bridiver
reviewed
Jul 11, 2017
| @@ -101,6 +101,7 @@ bool AtomContentUtilityClient::OnMessageReceived( | |||
|
|
|||
| bool handled = true; | |||
| IPC_BEGIN_MESSAGE_MAP(AtomContentUtilityClient, message) | |||
| IPC_MESSAGE_HANDLER(BraveUtilityMsg_GetImportFromChrome, OnImportFromChrome) | |||
There was a problem hiding this comment.
this doesn't seem necessary. The SourceProfile is sent to atom::ExternalProcessImporterClient and we can set the command line switch there
|
will do. and we need rebase this for cr60 |
fixes brave/browser-laptop#9434 Auditors: @bridiver, @bbondy, @diracdeltas, @bsclifton Mac: master password will store in Chrome/Chromium Safe Storage so we will ask users to access it Windows: Using `CryptProtectData` and `CryptUnprotectData` `Usually, the only user who can decrypt the data is a user with the same logon credentials as the user who encrypted the data` Linux: Using NativeBackEnd. gnome-keyring which will be removed soon is deprecated by libsecret KDE has a bug traking it #238
darkdh
force-pushed
the
import-pwd-chrome
branch
from
a424588 to
ceaab32
Compare
|
@bridiver , removed unnecessary IPC and rebased to cr60. Please review again. |
bridiver
approved these changes
Jul 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes brave/browser-laptop#9434
Auditors: @bridiver, @bbondy, @diracdeltas, @bsclifton
Mac:
master password will store in Chrome/Chromium Safe Storage
so we will ask users to access it
Windows:
Using
CryptProtectDataandCryptUnprotectDataUsually, the only user who can decrypt the data is a user with the same logon credentials as the user who encrypted the dataLinux:
Using NativeBackEnd.
gnome-keyring which will be removed soon is deprecated by libsecret
KDE has a bug traking it #238