Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Commit

Permalink
Fix lint issues
Browse files Browse the repository at this point in the history
* atom/browser/api/atom_api_session.cc:609:  Lines should be <= 80
  characters long  [whitespace/line_length] [2]
* atom/browser/api/atom_api_cookies.cc:218:  Missing username in TODO;
  it should look like "// TODO(my_username): Stuff."  [readability/todo]
  [2]
* atom/browser/api/atom_api_cookies.cc:218:  Should have a space between
  // and comment  [whitespace/comments] [4]
* atom/browser/api/atom_api_cookies.cc:219:  Should have a space between
  // and comment  [whitespace/comments] [4]
* atom/browser/api/atom_api_cookies.cc:220:  Lines should be <= 80
  characters long  [whitespace/line_length] [2]
* atom/browser/api/atom_api_cookies.cc:220:  Should have a space between
  // and comment  [whitespace/comments] [4]
* atom/browser/api/atom_api_cookies.cc:221:  Should have a space between
  // and comment  [whitespace/comments] [4]
  • Loading branch information
hferreiro committed Jun 30, 2017
1 parent da886a1 commit b1f130f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
9 changes: 5 additions & 4 deletions atom/browser/api/atom_api_cookies.cc
Original file line number Diff line number Diff line change
Expand Up @@ -215,10 +215,11 @@ Cookies::Cookies(v8::Isolate* isolate,
Cookies::~Cookies() {
}

//TODO: 2017.06.29 klawler
//Delete GetAll if possible (dependency in $MUON/lib/browser/api/extensions.js)
//Verify or implement that sorting occurs on cookies by 1. path length 2. creation date
//Possibly done here or in $MUON/lib/browser/api/extensions.js
// TODO(klawler): 2017.06.29
// Delete GetAll if possible (dependency in $MUON/lib/browser/api/extensions.js)
// Verify or implement that sorting occurs on cookies by 1. path length 2.
// creation date
// Possibly done here or in $MUON/lib/browser/api/extensions.js

void Cookies::GetAll(const base::DictionaryValue& filter,
const GetCallback& callback) {
Expand Down
3 changes: 2 additions & 1 deletion atom/browser/api/atom_api_session.cc
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,8 @@ mate::Handle<Session> Session::CreateFrom(
return mate::CreateHandle(isolate, static_cast<Session*>(existing));

auto handle = mate::CreateHandle(
isolate, new Session(isolate, Profile::FromBrowserContext(browser_context)));
isolate,
new Session(isolate, Profile::FromBrowserContext(browser_context)));

// The Sessions should never be garbage collected, since the common pattern is
// to use partition strings, instead of using the Session object directly.
Expand Down

0 comments on commit b1f130f

Please sign in to comment.