Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Commit

Permalink
store installed state in extension prefs
Browse files Browse the repository at this point in the history
  • Loading branch information
bridiver committed Oct 23, 2017
1 parent 51d7990 commit ad85233
Showing 1 changed file with 17 additions and 4 deletions.
21 changes: 17 additions & 4 deletions atom/browser/extensions/atom_extension_system.cc
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,14 @@ const Extension* AtomExtensionSystem::Shared::AddExtension(
DCHECK_GE(version_compare_result, 0);
}
}
registry_->TriggerOnWillBeInstalled(extension,
is_extension_upgrade, old_name);

bool is_install =
!extension_prefs_->GetInstalledExtensionInfo(extension->id()) ||
is_extension_upgrade;
if (is_install) {
registry_->TriggerOnWillBeInstalled(extension,
is_extension_upgrade, old_name);
}

// Set the upgraded bit; we consider reloads upgrades.
runtime_data()->SetBeingUpgraded(extension->id(),
Expand Down Expand Up @@ -352,6 +358,15 @@ const Extension* AtomExtensionSystem::Shared::AddExtension(
NotifyExtensionLoaded(extension);
}
runtime_data()->SetBeingUpgraded(extension->id(), false);

if (is_install) {
extension_prefs_->OnExtensionInstalled(
extension, Extension::ENABLED, syncer::StringOrdinal(),
extensions::kInstallFlagNone, std::string());

registry_->TriggerOnInstalled(extension, is_extension_upgrade);
}

return extension;
}

Expand Down Expand Up @@ -395,8 +410,6 @@ void AtomExtensionSystem::Shared::NotifyExtensionLoaded(
// NOTIFICATION_EXTENSION_LOADED_DEPRECATED, the
// renderer is guaranteed to know about it.
registry_->TriggerOnLoaded(extension);

registry_->TriggerOnInstalled(extension, false);
}

const Extension* AtomExtensionSystem::Shared::GetExtensionById(
Expand Down

0 comments on commit ad85233

Please sign in to comment.