-
Notifications
You must be signed in to change notification settings - Fork 971
Don't allow tab preview after close if config is off #9537
Conversation
826cb91
to
6d5dd4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concise. Appears to work. LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and test plan works 😄 👍
I did notice though that locally and on travis, one of the tests is failing:
https://travis-ci.org/brave/browser-laptop/jobs/244036926#L3204
Once that is resolved, this is ready for merge 😄
Auditors: @bsclifton Addresses #8902 (review)
6d5dd4a
to
bbe8cdc
Compare
sorry changed frameKey just before pushing. updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code works great and tests pass! Thanks, @cezaraugusto! 😄
Don't allow tab preview after close if config is off
Don't allow tab preview after close if config is off
Submitter Checklist:
git rebase -i
to squash commits (if needed).Issue first reported in #9306 (comment). cc @jonathansampson
Test Plan:
Manual Test Plan:
Reviewer Checklist:
Tests