Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

added first draft of release notes for 0.15.0 #8499

Merged
merged 3 commits into from
Apr 27, 2017
Merged

Conversation

alexwykoff
Copy link
Contributor

First draft of release notes.

Auditors: @bbondy @bsclifton @luixxiul

@luixxiul
Copy link
Contributor

Please keep the original titles of the issues somewhere if they have been changed. Changing even 1 word sometimes make it hard to find the issue with autocompleted queries, thanks to the poor GitHub search system (especially for foreign devs). This time I did it for you. Original title: foo or Old title: bar.

However I am not quite sure it would be a good practice to change the titles of the issues just to produce the release notes. I haven't seen it anywhere else. We also need to revert the title once the issue is reverted and someone will have to keep an eye on it.

Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog itself LGTM

@alexwykoff
Copy link
Contributor Author

@luixxiul agreed, there should be a smart way to generate notes and keep items searchable.

@Jacalz
Copy link
Contributor

Jacalz commented Apr 26, 2017

How about electron builder 17.1.1?
The rest looks good to me 👍

CHANGELOG.md Outdated
@@ -1,7 +1,71 @@
# Changelog

## [0.15.0](https://github.com/brave/browser-laptop/releases/v0.15.0dev)
- Update muon to 2.58.6. ([#8161](https://github.com/brave/browser-laptop/issues/8161))
- Added Widevine support for Amazon Prime Video. ([#5233](https://github.com/brave/browser-laptop/issues/5233))
- Added tear off tabs - Ability to drag tab into new window. ([#4402](https://github.com/brave/browser-laptop/issues/4402))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one doesn't read well.
Ability to tear off tabs and to combine them back into other windows.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also order this above widevine for prime video

CHANGELOG.md Outdated
- Update muon to 2.58.6. ([#8161](https://github.com/brave/browser-laptop/issues/8161))
- Added Widevine support for Amazon Prime Video. ([#5233](https://github.com/brave/browser-laptop/issues/5233))
- Added tear off tabs - Ability to drag tab into new window. ([#4402](https://github.com/brave/browser-laptop/issues/4402))
- Added user pinning in Brave Payments. ([#7347](https://github.com/brave/browser-laptop/issues/7347))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"user pinning" doesn't make sense to me for this feature. Maybe "ledger site pining"

CHANGELOG.md Outdated
- Added Widevine support for Amazon Prime Video. ([#5233](https://github.com/brave/browser-laptop/issues/5233))
- Added tear off tabs - Ability to drag tab into new window. ([#4402](https://github.com/brave/browser-laptop/issues/4402))
- Added user pinning in Brave Payments. ([#7347](https://github.com/brave/browser-laptop/issues/7347))
- Added support for Back/forward gesture with three finger swipe. ([#7905](https://github.com/brave/browser-laptop/issues/7905))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: space between / back / forward

CHANGELOG.md Outdated
- Changed about:preferences#extensions link to go to the extension request category in community. ([#8252](https://github.com/brave/browser-laptop/issues/8252))
- Fixed Brave crash when visiting Brave Twitter page. ([#8004](https://github.com/brave/browser-laptop/issues/8004))
- Fixed crash caused by certain pinned tabs. ([#7187](https://github.com/brave/browser-laptop/issues/7187))
- Fixed opening pdf in new tab fails to load. ([#8364](https://github.com/brave/browser-laptop/issues/8364))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit PDF

CHANGELOG.md Outdated
- Fixed bookmarks are re-synced (uploaded) on every load. ([#8408](https://github.com/brave/browser-laptop/issues/8408))
- Fixed messages shown on extensions page. ([#8318](https://github.com/brave/browser-laptop/issues/8318))
- Fixed extensions so they sort alphabetically. ([#8315](https://github.com/brave/browser-laptop/issues/8315))
- Fixed jumpy tab drag and drop. ([#8288](https://github.com/brave/browser-laptop/issues/8288))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be excluded please since we introduced it in the same version.

CHANGELOG.md Outdated
- Fixed jumpy tab drag and drop. ([#8288](https://github.com/brave/browser-laptop/issues/8288))
- Fixed homepage preference isn't being respected. ([#8278](https://github.com/brave/browser-laptop/issues/8278))
- Fixed screen reader can't identify extension button. ([#8269](https://github.com/brave/browser-laptop/issues/8269))
- Fixed tabs bar size by another 2 px based on increased user feedback. ([#8263](https://github.com/brave/browser-laptop/issues/8263))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no! My eyes are bleeding from seeing a space between the number and unit :P

CHANGELOG.md Outdated
- Fixed tabs bar size by another 2 px based on increased user feedback. ([#8263](https://github.com/brave/browser-laptop/issues/8263))
- Fixed memory leak when opening then closing a lot of tabs rapidly. ([#8244](https://github.com/brave/browser-laptop/issues/8244))
- Fixed about:brave copy to clipboard tooltip. ([#8199](https://github.com/brave/browser-laptop/issues/8199))
- Fixed wallet creation failure. ([#8195](https://github.com/brave/browser-laptop/issues/8195))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is newly introduced so should be excluded.

CHANGELOG.md Outdated
- Fixed invisible pinned tab after upgrade. ([#8190](https://github.com/brave/browser-laptop/issues/8190))
- Fixed URL bar shape consistency when payments are enabled/disabled. ([#8170](https://github.com/brave/browser-laptop/issues/8170))
- Fixed creating a bookmark by dragging the Url bar icon. ([#8151](https://github.com/brave/browser-laptop/issues/8151))
- Fixed save .torrent file action. ([#8146](https://github.com/brave/browser-laptop/issues/8146))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sub-bug of a feature that was added same version, exclude.

CHANGELOG.md Outdated
- Fixed save .torrent file action. ([#8146](https://github.com/brave/browser-laptop/issues/8146))
- Fixed image title. ([#8116](https://github.com/brave/browser-laptop/issues/8116))
- Fixed white tab text on dark tab background which is difficult to read. ([#8115](https://github.com/brave/browser-laptop/issues/8115))
- Fixed javascript in bookmarks cause connection info box to appear. ([#8087](https://github.com/brave/browser-laptop/issues/8087))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always JavaScript

CHANGELOG.md Outdated
- Fixed Sync does not appear to recover from network outage. ([#7972](https://github.com/brave/browser-laptop/issues/7972))
- Fixed Sync losing hierarchy when adding bookmarks to new sync members. ([#7971](https://github.com/brave/browser-laptop/issues/7971))
- Fixed localization ability for delete confirmation message. ([#7958](https://github.com/brave/browser-laptop/issues/7958))
- Fixed default browser setting Ubuntu. ([#7800](https://github.com/brave/browser-laptop/issues/7800))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting for Ubuntu

CHANGELOG.md Outdated
- Updated spinner animation on tab loads. ([#7779](https://github.com/brave/browser-laptop/issues/7779))
- Updated 1Password description on extensions page. ([#8465](https://github.com/brave/browser-laptop/issues/8465))
- Updated webtorrent description on extensions page. ([#8208](https://github.com/brave/browser-laptop/issues/8208))
- Upgraded to Chromium58. ([#8353](https://github.com/brave/browser-laptop/issues/8353))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicit chromium versions always in release notes pls.

CHANGELOG.md Outdated
- Updated webtorrent description on extensions page. ([#8208](https://github.com/brave/browser-laptop/issues/8208))
- Upgraded to Chromium58. ([#8353](https://github.com/brave/browser-laptop/issues/8353))
- Upgraded to muon 2.58.6. ([#8161](https://github.com/brave/browser-laptop/issues/8161))
- Upgraded to Node v7.9.0. ([#8483](https://github.com/brave/browser-laptop/issues/8483))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node before muon

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments left- otherwise looks good 😄

CHANGELOG.md Outdated
@@ -1,7 +1,71 @@
# Changelog

## [0.15.0](https://github.com/brave/browser-laptop/releases/v0.15.0dev)
- Update muon to 2.58.6. ([#8161](https://github.com/brave/browser-laptop/issues/8161))
- Added Widevine support for Amazon Prime Video. ([#5233](https://github.com/brave/browser-laptop/issues/5233))
- Added tear off tabs - Ability to drag tab into new window. ([#4402](https://github.com/brave/browser-laptop/issues/4402))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/drag tab into new/drag a tab into a new

CHANGELOG.md Outdated
- Update muon to 2.58.6. ([#8161](https://github.com/brave/browser-laptop/issues/8161))
- Added Widevine support for Amazon Prime Video. ([#5233](https://github.com/brave/browser-laptop/issues/5233))
- Added tear off tabs - Ability to drag tab into new window. ([#4402](https://github.com/brave/browser-laptop/issues/4402))
- Added user pinning in Brave Payments. ([#7347](https://github.com/brave/browser-laptop/issues/7347))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one doesn't make much sense as-is... Maybe it could be:
Added ability to pin publishers in Brave Payments

CHANGELOG.md Outdated
- Added tear off tabs - Ability to drag tab into new window. ([#4402](https://github.com/brave/browser-laptop/issues/4402))
- Added user pinning in Brave Payments. ([#7347](https://github.com/brave/browser-laptop/issues/7347))
- Added support for Back/forward gesture with three finger swipe. ([#7905](https://github.com/brave/browser-laptop/issues/7905))
- Added support for torrent link files. ([#6671](https://github.com/brave/browser-laptop/issues/6671))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this include the .? like Added support for .torrent links and files?

CHANGELOG.md Outdated
- Added user pinning in Brave Payments. ([#7347](https://github.com/brave/browser-laptop/issues/7347))
- Added support for Back/forward gesture with three finger swipe. ([#7905](https://github.com/brave/browser-laptop/issues/7905))
- Added support for torrent link files. ([#6671](https://github.com/brave/browser-laptop/issues/6671))
- Added noscript into the URL bar. ([#5792](https://github.com/brave/browser-laptop/issues/5792))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be useful to users as Added more draggable space by moving noscript into the URL bar

CHANGELOG.md Outdated
- Added temporary notice to sync prefs page regarding mobile sync and Beta label. ([#8121](https://github.com/brave/browser-laptop/issues/8121))
- Added a new tab page for private tabs. ([#7934](https://github.com/brave/browser-laptop/issues/7934))
- Added "Command+Click" to home button (opens home in a new background tab). ([#7718](https://github.com/brave/browser-laptop/issues/7718))
- Added origin display for downloads. ([#7468](https://github.com/brave/browser-laptop/issues/7468))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also be important to note Added origin for downloads, including unlock icon if download was insecure (HTTP)

CHANGELOG.md Outdated
- Fixed invisible pinned tab after upgrade. ([#8190](https://github.com/brave/browser-laptop/issues/8190))
- Fixed URL bar shape consistency when payments are enabled/disabled. ([#8170](https://github.com/brave/browser-laptop/issues/8170))
- Fixed creating a bookmark by dragging the Url bar icon. ([#8151](https://github.com/brave/browser-laptop/issues/8151))
- Fixed save .torrent file action. ([#8146](https://github.com/brave/browser-laptop/issues/8146))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one shouldn't be in here since .torrent was introduced this release also (with #6671)

- Added text badges for extensions. ([#5366](https://github.com/brave/browser-laptop/issues/5366))
- Added selection ability for torrent files. ([#8148](https://github.com/brave/browser-laptop/issues/8148))
- Added temporary notice to sync prefs page regarding mobile sync and Beta label. ([#8121](https://github.com/brave/browser-laptop/issues/8121))
- Added a new tab page for private tabs. ([#7934](https://github.com/brave/browser-laptop/issues/7934))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

CHANGELOG.md Outdated
- Fixed creating a bookmark by dragging the Url bar icon. ([#8151](https://github.com/brave/browser-laptop/issues/8151))
- Fixed save .torrent file action. ([#8146](https://github.com/brave/browser-laptop/issues/8146))
- Fixed image title. ([#8116](https://github.com/brave/browser-laptop/issues/8116))
- Fixed white tab text on dark tab background which is difficult to read. ([#8115](https://github.com/brave/browser-laptop/issues/8115))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed readability issues with white text on dark colored tabs

CHANGELOG.md Outdated
- Fixed view source shortcut to be CTRL+U, not CTRL+ALT+U. ([#7702](https://github.com/brave/browser-laptop/issues/7702))
- Fixed submenu position for bookmarks. ([#7662](https://github.com/brave/browser-laptop/issues/7662))
- Fixed right click not dismissing / hiding an open menu. ([#7403](https://github.com/brave/browser-laptop/issues/7403))
- Fixed default browser setting reset after upgrade. ([#5246](https://github.com/brave/browser-laptop/issues/5246))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would vote to move this to the very top since it has a massive impact; it should also include Windows, like:
Fixed issue where default browser was reset after upgrade on Windows

CHANGELOG.md Outdated
- Added noscript into the URL bar. ([#5792](https://github.com/brave/browser-laptop/issues/5792))
- Added "Extensions..." to window menu. ([#8203](https://github.com/brave/browser-laptop/issues/8203))
- Added stop button for torrent downloads. ([#6768](https://github.com/brave/browser-laptop/issues/6768))
- Added extensions panel to about:preferences. ([#6530](https://github.com/brave/browser-laptop/issues/6530))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extension manager is huge- maybe moving up a bit

@bbondy bbondy merged commit d1fc13c into master Apr 27, 2017
@luixxiul
Copy link
Contributor

unfortunately there appeared a case where changing title strategy did not work: #8146

@luixxiul luixxiul deleted the 0_15_0_release_notes branch April 29, 2017 04:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants