-
Notifications
You must be signed in to change notification settings - Fork 971
Add support for Enpass password manager. #6493
Add support for Enpass password manager. #6493
Conversation
@calavera this is pretty awesome, thanks! @bbondy, @bradleyrichter, @bridiver - what do you all think of including Enpass as well? |
I'm ok with this if others are since brave/vault-updater is automated now for extension updates, thanks for the pull request. One quick change at least though is that for the language files only en_US should be updated, the others are auto generated files. Also I'd have to update our brave/vault-updater code to include it. |
@bbondy thanks for the info, I'll revert the changes in the properties to change only en_US. I can also update vault-updater. |
edad934
to
ab5ac1b
Compare
I removed my translations, except en-US. I don't know why the tests fail, tbh, it looks like it's not related to my changes, but I'm not sure. |
++ looks great to me, we'll merge it for 0.13.1 because we're already frozen for 0.13 |
Thanks @bbondy! 🎉 I checked the updater and it looks like the automatic process requires access to S3 and what not to be correct, so I guess you should update the extensions manifest there. If I try to update only the manifest, I might even make you work even more |
I changed the base branch to brave:0.13.1-branch just now :-) |
bd9183d
to
2789018
Compare
ab5ac1b
to
3861396
Compare
Rebased; will merge after reviewing CI tests |
aceaf39
to
8190b88
Compare
@bsclifton this seems to have unrelated changes, maybe a rebase issue? |
Rebased on #6824 |
46ff336
to
6d3ed6d
Compare
4e72eb0
to
2bcf169
Compare
@bridiver definitely my bad- was rebasing and lost track of this Updated! 😄 |
6d3ed6d
to
0fb932c
Compare
2bcf169
to
1d98e22
Compare
65c7753
to
238cfd3
Compare
This change adds support for Enpass password manager using the compatible Chrome extension: https://chrome.google.com/webstore/detail/enpass-password-manager/kmcfomidfpdkfieipokbalgegidffkal?hl=en-US This extension requires an external application, just like 1Password. Fixes brave#5097 Signed-off-by: David Calavera <[email protected]>
1d98e22
to
ea87980
Compare
I re-ran the tests which failed with the last CI run and they're working good, except for this one: @bbondy what do we need to do to get the enpass extension loaded in our store? |
Merging! |
This change adds support for Enpass password manager using the compatible Chrome extension:
https://chrome.google.com/webstore/detail/enpass-password-manager/kmcfomidfpdkfieipokbalgegidffkal?hl=en-US
This extension requires an external application, just like 1Password.
TESTING
I've added tests similar to the ones present for other password managers.
The Enpass desktop applications are free if this requires more testing, you can download them from https://www.enpass.io/downloads.
Fixes #5097
Signed-off-by: David Calavera [email protected]