Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add support for Enpass password manager. #6493

Merged
merged 1 commit into from
Jan 25, 2017

Conversation

calavera
Copy link
Contributor

@calavera calavera commented Dec 31, 2016

This change adds support for Enpass password manager using the compatible Chrome extension:

https://chrome.google.com/webstore/detail/enpass-password-manager/kmcfomidfpdkfieipokbalgegidffkal?hl=en-US

This extension requires an external application, just like 1Password.

TESTING

I've added tests similar to the ones present for other password managers.

The Enpass desktop applications are free if this requires more testing, you can download them from https://www.enpass.io/downloads.

Fixes #5097

Signed-off-by: David Calavera [email protected]

@bsclifton
Copy link
Member

@calavera this is pretty awesome, thanks!

@bbondy, @bradleyrichter, @bridiver - what do you all think of including Enpass as well?

@bbondy
Copy link
Member

bbondy commented Jan 2, 2017

I'm ok with this if others are since brave/vault-updater is automated now for extension updates, thanks for the pull request. One quick change at least though is that for the language files only en_US should be updated, the others are auto generated files.

Also I'd have to update our brave/vault-updater code to include it.

@calavera
Copy link
Contributor Author

calavera commented Jan 2, 2017

@bbondy thanks for the info, I'll revert the changes in the properties to change only en_US.

I can also update vault-updater.

@calavera calavera force-pushed the enpass_password_manager branch from edad934 to ab5ac1b Compare January 2, 2017 21:23
@calavera
Copy link
Contributor Author

calavera commented Jan 2, 2017

I removed my translations, except en-US. I don't know why the tests fail, tbh, it looks like it's not related to my changes, but I'm not sure.

@bbondy
Copy link
Member

bbondy commented Jan 3, 2017

++ looks great to me, we'll merge it for 0.13.1 because we're already frozen for 0.13

@calavera
Copy link
Contributor Author

calavera commented Jan 3, 2017

Thanks @bbondy! 🎉

I checked the updater and it looks like the automatic process requires access to S3 and what not to be correct, so I guess you should update the extensions manifest there. If I try to update only the manifest, I might even make you work even more

@luixxiul luixxiul added this to the 0.13.1 milestone Jan 14, 2017
@luixxiul luixxiul changed the base branch from master to 0.13.1-branch January 18, 2017 16:21
@luixxiul
Copy link
Contributor

I changed the base branch to brave:0.13.1-branch just now :-)

@bsclifton bsclifton force-pushed the 0.13.1-branch branch 4 times, most recently from bd9183d to 2789018 Compare January 23, 2017 17:20
@bsclifton bsclifton requested a review from bbondy January 23, 2017 23:58
@bsclifton bsclifton force-pushed the enpass_password_manager branch from ab5ac1b to 3861396 Compare January 24, 2017 00:05
@bsclifton
Copy link
Member

Rebased; will merge after reviewing CI tests

@bridiver
Copy link
Collaborator

@bsclifton this seems to have unrelated changes, maybe a rebase issue?

@luixxiul
Copy link
Contributor

Rebased on #6824

@bsclifton
Copy link
Member

@bridiver definitely my bad- was rebasing and lost track of this

Updated! 😄

This change adds support for Enpass password manager using
the compatible Chrome extension:

https://chrome.google.com/webstore/detail/enpass-password-manager/kmcfomidfpdkfieipokbalgegidffkal?hl=en-US

This extension requires an external application, just like 1Password.

Fixes brave#5097

Signed-off-by: David Calavera <[email protected]>
@bsclifton bsclifton force-pushed the enpass_password_manager branch from 1d98e22 to ea87980 Compare January 25, 2017 19:20
@bsclifton
Copy link
Member

I re-ran the tests which failed with the last CI run and they're working good, except for this one:
npm run test -- --grep="about:extensions Enpass installs when enabled installs"

@bbondy what do we need to do to get the enpass extension loaded in our store?

@bsclifton
Copy link
Member

Merging!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants