This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Crash reporting toggle in advanced > preferences #4589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add toggle in advanced preferences to enable or disable crash reporting * Enable crash reporting on startup if preferences selected Auditors: @bbondy Test Plan: * Navigate to Preferences > Advanced * Toggle crash reporting to off (restart browser) * Load browser and select crash from debug menu -> Confirm crash report NOT sent to stats.brave.com * Load browser and navigate to Preferences > Advanced * Toggle crash reporting to on (restart browser) * Load browser and select crash from debug menu -> Confirm crash report SENT to stats.brave.com
* Enable crash reporting on undefined or true value in setting * Update state documentation Auditors: @bbondy Test Plan: In previous commit
|
Found a couple more required changes to make |
|
sorry to add extra work for you, but we really need the crash reports for mac :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4479
Test Plan:
-> Confirm crash report NOT sent to stats.brave.com
-> Confirm crash report SENT to stats.brave.com
cc @bridiver @bsclifton @bbondy