This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Prevent two-finger swipe forard/back when scrolling on viewport #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit can only prevent conflicts on non-inner scrollable element like |
|
does Chrome work any better? |
|
Chrome perform swipe forward/back based on reaching the edge of viewport. |
| ipc.on('scroll-touch-begin', function () { | ||
| trackingFingers = true | ||
| startTime = (new Date()).getTime() | ||
| }) | ||
| ipc.on('scroll-touch-end', function () { | ||
| if (trackingFingers && Math.abs(yVelocity) < 1) { | ||
| if (!isScroll && trackingFingers && Math.abs(yVelocity) < 1) { | ||
| if (xVelocity > 1.5) { |
There was a problem hiding this comment.
I think you can change the xVelocity threshold to 1 or 0.5 to make it easier to go back/forward now
|
good idea |
|
about 656d56d:
|
|
Is IPC possible here? Just wondering why the console.log hack. Is it more efficient for some reason? |
|
@bbondy , your are right. I should use IPC. I just came up with console.log from nowhere. |
darkdh
changed the title
|
looks great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits if needed.fix #2577