Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add tor loading progress UI #14395

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Add tor loading progress UI #14395

merged 1 commit into from
Jun 14, 2018

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jun 12, 2018

Fix #14043

Test Plan:

Success case:

  1. start brave
  2. immediately open a tor private tab
  3. you should briefly see a loading message in the URLbar
  4. once loading is finished, you should be able to type in the URLbar

Fail case:

  1. start an HTTP listener on port 9250 (so that Tor cannot bind to it.
    this causes Tor to not be able to connect).
  2. start brave
  3. open tor tab and wait for 20s
  4. you should see an error message pop up
  5. the button and link in the error message should work as expected

screen shot 2018-06-12 at 4 40 08 pm

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fix #14043

Test Plan:

Success case:
1. start brave
2. immediately open a tor private tab
3. you should briefly see a loading message in the URLbar
4. once loading is finished, you should be able to type in the URLbar

Fail case:
1. start an HTTP listener on port 9250 (so that Tor cannot bind to it.
   this causes Tor to not be able to connect).
2. start brave
3. open tor tab and wait for 20s
4. you should see an error message pop up
5. the button and link in the error message should work as expected
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely. We can refine styles once tor/0.23.x is rebased to include the style refresh 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants