Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes captcha clear on tab close/restart #14294

Merged
merged 1 commit into from
May 31, 2018
Merged

Fixes captcha clear on tab close/restart #14294

merged 1 commit into from
May 31, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 31, 2018 •
edited
Loading

Resolves #14279

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

defined in #14279

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc self-assigned this May 31, 2018
@NejcZdovc NejcZdovc requested a review from ryanml May 31, 2018 06:34
@NejcZdovc NejcZdovc requested a review from jasonrsadler May 31, 2018 16:13
jasonrsadler
jasonrsadler approved these changes May 31, 2018
View reviewed changes
Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Good fix! 🥇

@NejcZdovc NejcZdovc merged commit dec75c3 into brave:master May 31, 2018
NejcZdovc added a commit that referenced this pull request May 31, 2018
@NejcZdovc
Merge pull request #14294 from NejcZdovc/fix/#14279-check
b44a37a 
Fixes captcha clear on tab close/restart
NejcZdovc added a commit that referenced this pull request May 31, 2018
@NejcZdovc
Merge pull request #14294 from NejcZdovc/fix/#14279-check
155c223 
Fixes captcha clear on tab close/restart
@NejcZdovc
Copy link
Contributor Author

master dec75c3
0.23 b44a37a
0.22 155c223

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jasonrsadler jasonrsadler jasonrsadler approved these changes

@ryanml ryanml Awaiting requested review from ryanml

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.22.x Release 5 (Release channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @jasonrsadler