Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add default exception for uphold.com for fingerprint protection (sinc… #14158

Merged
merged 1 commit into from
May 17, 2018
Merged

Add default exception for uphold.com for fingerprint protection (sinc… #14158

merged 1 commit into from
May 17, 2018

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented May 17, 2018

…e we partner for them for funding/publishers)

Fixes #14152

Auditors: @diracdeltas

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. Fresh profile- visit https://uphold.com
  2. Click shields button
  3. Fingerprinting protection should be set to Allow all fingerprinting

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton added this to the 0.22.x Release 4 (Beta channel) milestone May 17, 2018
@bsclifton bsclifton self-assigned this May 17, 2018
@bsclifton bsclifton requested a review from diracdeltas May 17, 2018 06:13
@bsclifton
Copy link
Member Author

Security review opened: https://github.com/brave/internal/issues/334

diracdeltas
diracdeltas previously approved these changes May 17, 2018
@bsclifton
Copy link
Member Author

Just noticed the failing test - working on fixing that up

…e we partner for them for funding/publishers)

Fixes #14152

Auditors: @diracdeltas
@bsclifton bsclifton merged commit 54f6b31 into brave:master May 17, 2018
@bsclifton bsclifton deleted the uphold-fingerprint-exception branch May 17, 2018 16:42
bsclifton added a commit that referenced this pull request May 17, 2018
Add default exception for uphold.com for fingerprint protection (sinc…
bsclifton added a commit that referenced this pull request May 17, 2018
Add default exception for uphold.com for fingerprint protection (sinc…
@bsclifton
Copy link
Member Author

master 54f6b31
0.23.x d0dcebf
0.22.x 10144c0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants