Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes issue #13322 - Escape single quotes in url bookmark imports #13635

Closed
wants to merge 1 commit into from
Closed

Fixes issue #13322 - Escape single quotes in url bookmark imports #13635

wants to merge 1 commit into from

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Mar 28, 2018 •
edited
Loading

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

PR/needs-review @bsclifton
PR/security-review-requested @diracdeltas

Fixes issue #13322

@bsclifton bsclifton added this to the 0.24.x (Nightly Channel) milestone Mar 28, 2018
@diracdeltas
Copy link
Member

lgtm security-wise

@diracdeltas diracdeltas removed their request for review April 2, 2018 19:31
@jasonrsadler
Copy link
Contributor Author

jasonrsadler commented May 2, 2018 •
edited
Loading

This issue was resolved with 122aa70. Closing in favor.

jasonrsadler referenced this pull request May 2, 2018
@petemill
Calculate bookmarks bar overflow using css
122aa70 
Fix #13695

Remove usage of textCalc as it was the last usage of tabs.executeScriptInBackground which is not compatible with upcoming muon v6.x since as it incorrectly used executeScriptInTab which should only work on a WebContents which is a Tab, not a Window. Muon does not have a generic WebContents.executeJavascript method.

Also added bonus of not requiring creating new Windows in order to calculate text width and having to manage when they are closed, etc which should address the following issues, if that was the cause:
Fix #13422
Fix #13277
@jasonrsadler jasonrsadler deleted the working-dir4 branch May 2, 2018 01:57
@bsclifton bsclifton removed this from the 0.24.x (Nightly Channel) milestone May 2, 2018
@bsclifton
Copy link
Member

Removed milestone since issue was resolved with another commit

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@jasonrsadler jasonrsadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonrsadler @diracdeltas @bsclifton