This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 970
Properly handle bookmarks/history session migration (w/ regard to split sites) #12369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up to: - 9ad7b4f - 0dfd283 Auditors: @NejcZdovc
Also adds tests for remaining site split migration items: - bookmarks - cache - history Fixes #10595 Auditor: @NejcZdovc
PR is broken into two commits because 7caf16a was originally done back in September and does live in 0.21.x and 0.20.x, but for some reason is not in master |
Codecov Report
@@ Coverage Diff @@
## master #12369 +/- ##
==========================================
+ Coverage 55.34% 56.41% +1.07%
==========================================
Files 276 277 +1
Lines 26758 27563 +805
Branches 4315 4749 +434
==========================================
+ Hits 14808 15551 +743
- Misses 11950 12012 +62
|
NejcZdovc
approved these changes
Dec 22, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ looks good to me, really nice job on the tests ❤️
NejcZdovc
added a commit
that referenced
this pull request
Dec 22, 2017
Properly handle bookmarks/history session migration (w/ regard to split sites)
NejcZdovc
added a commit
that referenced
this pull request
Dec 22, 2017
Properly handle bookmarks/history session migration (w/ regard to split sites)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Fixes #10595
Automated test Plan:
npm run unittest -- --grep="sessionStore unit tests"
Manual test plan
Install 0.20.x and launch into the same profile folder used for step 1 (because 0.20.x builds are beta, they use a different profile directory. You can launch using the
--user-data-dir-name=
param to ensure it uses the same profileVerify you're on 0.20.x and that everything is present
Reviewer Checklist:
Tests