This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 972
Fixes Other bookmarks not being usable #10610
Merged
cezaraugusto
merged 1 commit into
brave:master
from
NejcZdovc:hotfix/#10157-otherBookmarks
Sep 28, 2017
Merged
Fixes Other bookmarks not being usable #10610
cezaraugusto
merged 1 commit into
brave:master
from
NejcZdovc:hotfix/#10157-otherBookmarks
Sep 28, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR is blocked by #10325, because we change some logic in it |
NejcZdovc
force-pushed
the
hotfix/#10157-otherBookmarks
branch
from
August 21, 2017 11:42
440661c
to
e021002
Compare
Codecov Report
@@ Coverage Diff @@
## master #10610 +/- ##
==========================================
- Coverage 54.19% 54.15% -0.05%
==========================================
Files 255 255
Lines 22079 22081 +2
Branches 3448 3449 +1
==========================================
- Hits 11966 11958 -8
- Misses 10113 10123 +10
|
8 tasks
8 tasks
ghost
added
the
sprint/1
label
Sep 13, 2017
NejcZdovc
force-pushed
the
hotfix/#10157-otherBookmarks
branch
from
September 18, 2017 05:18
e021002
to
d6de9fc
Compare
Resolves brave#10157 Resolves brave#4202 Auditors: Test Plan:
NejcZdovc
force-pushed
the
hotfix/#10157-otherBookmarks
branch
from
September 26, 2017 18:00
d6de9fc
to
33b6788
Compare
cezaraugusto
approved these changes
Sep 28, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
bsclifton
reviewed
Sep 28, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Resolves #10157
Resolves #4202
Auditors:
Test Plan:
Reviewer Checklist:
Tests