Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

“View source” breaks out of Private Tabs #4069

Closed
da2x opened this issue Sep 16, 2016 · 0 comments
Closed

“View source” breaks out of Private Tabs #4069

da2x opened this issue Sep 16, 2016 · 0 comments

Comments

@da2x
Copy link
Contributor

da2x commented Sep 16, 2016

  1. Open a private tab and load any website
  2. Right click on the page and choose Show Source

Expected: Show page source to be loaded in a private tab. (Shouldn’t need to load the resource anew – that is the core issue here.)

Actual: Loads resource a new in a non-private tab. Leaks information about private website.

Easier to test with a website where you’re logged in as a normal user but not logged in from within the private tab. The tab source will show your logged in state and identifiable information (e.g. your Google account name if you test on YouTube.)

This week’s dev build (no unique identifier in the about dialog?)

@Sh1d0w Sh1d0w added the bug label Sep 17, 2016
@Sh1d0w Sh1d0w self-assigned this Sep 17, 2016
MKuenzi pushed a commit to MKuenzi/browser-laptop that referenced this issue Sep 18, 2016
Fixes brave#4069

@bbondy

Test Plan:
Open a private tab and load any website
Right click on the page and choose Show Source
@luixxiul luixxiul added this to the 0.12.2dev milestone Sep 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants