Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Implement cosmetic adblock filters #344

Closed
bbondy opened this issue Jan 26, 2016 · 12 comments
Closed

Implement cosmetic adblock filters #344

bbondy opened this issue Jan 26, 2016 · 12 comments
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. design A design change, especially one which needs input from the design team. feature/adblock webcompat wontfix

Comments

@bbondy
Copy link
Member

bbondy commented Jan 26, 2016

This is partially implemented but we need to expose the support from the abp-filter-parser-cpp node module.

List of sites to check:

  • reddit.com ads removed, but not replaced
  • google search text ads neither removed nor replaced
@luixxiul luixxiul changed the title Implement cosmetic filters Implement cosmetic adblock filters May 22, 2016
@cezaraugusto cezaraugusto added enhancement design A design change, especially one which needs input from the design team. labels Jun 15, 2016
@luixxiul luixxiul added this to the 1.1.0 milestone Nov 9, 2016
@TerrySlack
Copy link

Ads are appearing in brave mobile. The only way I can turn them off is to turn scripts off in the badge, which isn't a long term solution.

@jonathansampson
Copy link
Collaborator

@bbondy Thoughts on solving via the approach in #7525? This issue feels like it may need a more robust solution.

@bbondy
Copy link
Member Author

bbondy commented Mar 11, 2017

I think that's ok as a temporary thing but we want something different for the generalized approach and understanding / converting ABP filter syntax for css rules. (Most of that is already supported just not used today)

@srirambv
Copy link
Collaborator

@jonathansampson
Copy link
Collaborator

One limitation in using the manifest (presently) is that we aren't checking if the user has Replace Ads enabled. We'll want to check that before loading any styles to hide elements, or scripts to remove nodes.

@srirambv
Copy link
Collaborator

@alexwykoff alexwykoff modified the milestones: 1.1.0, Backlog Nov 1, 2017
@quesada
Copy link

quesada commented Dec 21, 2017

I see adword ads on google search results. The first time I see them in 15 years using an adblocker in other browsers. Considering that this is your UVP, I expected better.

@dumptyd
Copy link

dumptyd commented Jan 4, 2018

This seems to be a somewhat known bug but I see empty spaces on every site where the ads would be.
This is what reddit and youtube look like on Brave.

image

image

@srirambv
Copy link
Collaborator

@Reonu
Copy link

Reonu commented Apr 12, 2018

Please fix this. It negates a large part of the reason to block ads in the first place :(

@mgonto
Copy link

mgonto commented Jul 2, 2018

+1

@bsclifton bsclifton added the addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. label Jul 2, 2018
@bsclifton
Copy link
Member

This is underway currently in Brave Core by @Snuupy! Since this won't be addressed in our current codebase (Muon), I'm going to close this issue as wontfix

For more info about the fix we ARE doing, subscribe to brave/brave-browser#94 and watch for updates 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. design A design change, especially one which needs input from the design team. feature/adblock webcompat wontfix
Projects
None yet
Development

No branches or pull requests