-
Notifications
You must be signed in to change notification settings - Fork 972
Implement cosmetic adblock filters #344
Comments
Ads are appearing in brave mobile. The only way I can turn them off is to turn scripts off in the badge, which isn't a long term solution. |
I think that's ok as a temporary thing but we want something different for the generalized approach and understanding / converting ABP filter syntax for css rules. (Most of that is already supported just not used today) |
+1 from community https://community.brave.com/t/adblock-isnt-good/1705 |
One limitation in using the manifest (presently) is that we aren't checking if the user has Replace Ads enabled. We'll want to check that before loading any styles to hide elements, or scripts to remove nodes. |
I see adword ads on google search results. The first time I see them in 15 years using an adblocker in other browsers. Considering that this is your UVP, I expected better. |
Please fix this. It negates a large part of the reason to block ads in the first place :( |
+1 |
This is underway currently in Brave Core by @Snuupy! Since this won't be addressed in our current codebase (Muon), I'm going to close this issue as For more info about the fix we ARE doing, subscribe to brave/brave-browser#94 and watch for updates 😄 |
This is partially implemented but we need to expose the support from the abp-filter-parser-cpp node module.
List of sites to check:
The text was updated successfully, but these errors were encountered: