Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Some Ads are not blocked #2369

Closed
nirnaybansal opened this issue Jul 2, 2016 · 8 comments
Closed

Some Ads are not blocked #2369

nirnaybansal opened this issue Jul 2, 2016 · 8 comments

Comments

@nirnaybansal
Copy link

nirnaybansal commented Jul 2, 2016

Did you search for similar issues before submitting this one?
No

Describe the issue you encountered:
Open: http://www.desirulez.me/forums/3883-Dahleez
See the ad on the top, with girls images.
Ads are not blocked.

Expected behavior:
Ad should be blocked

@hgareeballa
Copy link

same issue also in this website:
https://yifymovie.re/

@neeklamy
Copy link
Contributor

neeklamy commented Jul 2, 2016

On the Dahleez site, are you referring to the strip of adverts at the top of the page?

I think Brave uses Adblock Plus for its filters, the ABP extension on Google Chrome just so happens to let the same adverts through and disallowing non-intrusive adverts didn’t change that. If it is, then you can report it as a bug to ABP.

As for the second site, I’m not seeing any adverts (in either Brave or Google Chrome with ad blocking disabled), could you get a URL and screenshot of a page it appears on?

(Side note, I’d be wary of spending much time on YIFY Movie, I got a whole load of malware pages pop-up for “Adobe Flash” and the like, who knows what other malware they’re pushing.)

@hgareeballa
Copy link

screenshot_1
screenshot_2

Attached screen shot,
you need to click on any of the movie link to get the popup

@neeklamy
Copy link
Contributor

neeklamy commented Jul 2, 2016

@hgareeballa, those aren’t exactly adverts, it would broadly come under malware. Brave uses @bbondy’s abp-filter-parser-cpp project (so yes, it uses Adblock Plus), which in turn uses a few adblock lists

Possibly related: brave-experiments/ad-block#11 and brave-experiments/ad-block#21 (Google Chrome with Adblock Plus successfully blocks adverts on both those sites, so that suggests it’s an issue with abp-filter-parser-cpp).

@hgareeballa
Copy link

its still anoying and it would be great if Brave can somehow block them,
in Chome not all adblock can block it,, only few like "Stands"
image

so its good if Brave can do the same!

@neeklamy
Copy link
Contributor

neeklamy commented Jul 2, 2016

Interesting, I’d never heard of Stands or the Fair AdBlock, wondering if the Brave developers have seen it. Shame it’s not really open source though, makes it a bit harder to see how it blocks those pop-ups.

@myfavoriteemail
Copy link

http://oferta.senasofiaplus.edu.co/sofia-oferta/

is it possible to remove popovers/modals like the one poping out from this site? thank u!!!!!!!!!!

@luixxiul
Copy link
Contributor

luixxiul commented Sep 7, 2016

Closing this in favor of #344

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants