Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

block loading of chrome://brave URLs #15074

Closed
diracdeltas opened this issue Aug 21, 2018 · 2 comments · Fixed by #15076
Closed

block loading of chrome://brave URLs #15074

diracdeltas opened this issue Aug 21, 2018 · 2 comments · Fixed by #15076
Assignees
@diracdeltas
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include security
Milestone
0.23.x Release 5 ...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Aug 21, 2018 •
edited
Loading

talking to @bridiver and @darkdh it seems easiest to block chrome://brave loads in browser-laptop vs in muon. i believe navigation to chrome://brave is already blocked so we just need to block user-initiated loads.

this is a follow-up to #15045
@diracdeltas diracdeltas self-assigned this Aug 21, 2018
@diracdeltas
Copy link
Member Author

Will DM test plan to QA

@diracdeltas diracdeltas changed the title block loading of chrome:// URLs block loading of chrome://brave URLs Aug 21, 2018
diracdeltas added a commit that referenced this issue Aug 21, 2018
@diracdeltas
block chrome://brave URL loads
09d2453 
fix #15074

Test Plan:
DM'ed
@diracdeltas diracdeltas mentioned this issue Aug 21, 2018
Merged
10 tasks
This was referenced Aug 23, 2018
Closed
Closed
Closed
@btlechowski
Copy link
Contributor

btlechowski commented Aug 23, 2018 •
edited by srirambv
Loading

Verified on Ubuntu 17.10 x64

  • 0.23.104 b454a4a
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

Verified with macOS 10.12.6 using

  • 0.23.104 b454a4a
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

Verified on Windows 10 x64 using

  • 0.23.104 b454a4a
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

@kjozwiak kjozwiak mentioned this issue Aug 28, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include security
Projects
None yet
Milestone
0.23.x Release 5 (Release Channel)
Development

Successfully merging a pull request may close this issue.

block chrome://brave URL loads brave/browser-laptop
5 participants
@diracdeltas @bsclifton @srirambv @LaurenWags @btlechowski