Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

reducing time for the ref headers fetch at startup #15067

Closed
kjozwiak opened this issue Aug 21, 2018 · 1 comment
Closed

reducing time for the ref headers fetch at startup #15067

kjozwiak opened this issue Aug 21, 2018 · 1 comment
Assignees
@NejcZdovc
Labels
bug OS/macOS OS/Windows QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.23.x Release 5 ...

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Aug 21, 2018 •
edited
Loading

Test plan

  1. download 0.23.104
  2. create an empty brave profile and add promoCode which includes dowjones-barrons or dowjones-marketwatch
  3. launch brave, you should see a dj-barrons or dj-marketwatch tab at startup

Original Issue

Description

Because of #14620, we fetch the headers anywhere between 30s -1min after startup. Because of this change, users won't see the promotion tab at startup when installing either MW/Barrons (dowjones promotion). Users might not wait the 1min and just assume that the promotion is either over or broken.

Steps to Reproduce

  1. Download one of the promotional executables from either https://brave.com/dowjones-barrons or https://brave.com/dowjones-marketwatch
  2. Once downloaded, install the build and launch Brave
  3. Wait 30s - 1min and you'll notice the promotional tab will finally appear

Actual result:

https://youtu.be/KhM8GmenI4k

Expected result:

Promotional tabs should appear a few seconds after startup and not 30s -1min after startup. Might give the users the impressing that it's either broken or the promotion has ended.

Reproduces how often:

100% reproducible using the above STR.

Brave Version

about:brave info:

Brave: 0.23.79 
V8: 6.8.275.24 
rev: 51b49051a779f0db94fbcfd0df5faca781299ea0 
Muon: 8.0.7 
OS Release: 17.7.0 
Update Channel: Release 
OS Architecture: x64 
OS Platform: macOS 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 68.0.3440.84

Reproducible on current live release:

Yes, currently reproducible on 0.23.79 51b4905 which is the current live version.

Additional Information
@NejcZdovc NejcZdovc self-assigned this Aug 21, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 21, 2018
@NejcZdovc
Removes delay for referral
5875c29 
Resolves brave#15067

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Aug 21, 2018
Merged
10 tasks
This was referenced Aug 23, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Aug 23, 2018 •
edited by kjozwiak
Loading

Verified on Windows 10 x64

  • 0.23.104 b454a4a
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

Verified on macOS 10.13.6 x64 using the following builds:

  • 0.23.104 b454a4a
  • muon 8.0.8
  • libchromiumcontent 68.0.3440.84

@kjozwiak kjozwiak mentioned this issue Aug 28, 2018
Closed
pull bot pushed a commit to security-geeks/browser-laptop that referenced this issue Sep 18, 2018
@bsclifton
Merge pull request brave#15068 from NejcZdovc/hotfix/brave#15067-delay
0df0a5f 
Removes delay for referral
@kjozwiak kjozwiak mentioned this issue Oct 23, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug OS/macOS OS/Windows QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.23.x Release 5 (Release Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @bsclifton @NejcZdovc @srirambv @btlechowski