Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Shields icon needs fill color #14551

Closed
petemill opened this issue Jun 25, 2018 · 2 comments
Closed

Shields icon needs fill color #14551

petemill opened this issue Jun 25, 2018 · 2 comments
Assignees
Labels

Comments

@petemill
Copy link
Member

petemill commented Jun 25, 2018

As requested by @bradleyrichter at #13981 (comment), the shields logo (brave logo) needs to not have a transparent face, but be filled-in for all states.

Transparent face:
image

Filled-in face:
image

Test plan

Disabled

image

Enabled

image

Hover

image

Active

image

Brave: 0.23.14
V8: 6.7.288.46
rev: f4da855
Muon: 7.1.1
OS Release: 17.5.0
Update Channel: Beta
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 67.0.3396.87

@petemill petemill added the design A design change, especially one which needs input from the design team. label Jun 25, 2018
@petemill petemill added this to the 0.23.x (Beta Channel) milestone Jun 25, 2018
@petemill petemill self-assigned this Jun 25, 2018
@bradleyrichter
Copy link
Contributor

bradleyrichter commented Jun 25, 2018 via email

@btlechowski
Copy link
Contributor

btlechowski commented Jun 26, 2018

Verified on Ubuntu 17.10 x64

  • 0.23.18 - c101002
  • Muon - 7.1.2
  • libchromiumcontent - 67.0.3396.87

Verified on Windows 10 x64
• 0.23.18 c101002
• Muon 7.1.2
• libchromiumcontent: 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.18 c101002
  • Muon 7.1.2
  • libchromiumcontent 67.0.3396.87

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants