Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Arrow should not be allowed to drag and drop on Brave Payments BAT logo page #14274

Closed
GeetaSarvadnya opened this issue May 30, 2018 · 6 comments
Closed

Arrow should not be allowed to drag and drop on Brave Payments BAT logo page #14274

GeetaSarvadnya opened this issue May 30, 2018 · 6 comments
Assignees
@NejcZdovc
Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.22.x Release 5 ...

Comments

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented May 30, 2018 •
edited
Loading

Description

Arrow should not be allowed to drag and drop on Brave Payments BAT logo page

Steps to Reproduce

  1. Drag and drop the arrow
  2. Verify Arrow can be drag and drop

Actual result:

After drag and drop of Arrow (->), 'Hmm..not quite Please try again' message is displayed

arrow drag and drop issue

Expected result:

Arrow should not be drag and dropped and message should be displayed only for BAT logo drag and drop

Reproduces how often:
100%

Brave Version

0.22.723

about:brave info:

Brave | 0.22.723
V8 | 6.6.346.32
rev | edb3e88
Muon | 6.0.12
OS Release | 10.0.16299
Update Channel | Release
OS Architecture | x64
OS Platform | Microsoft Windows
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 66.0.3359.170

Reproducible on current live release:

Additional Information
@GeetaSarvadnya GeetaSarvadnya added this to the Triage Backlog milestone May 30, 2018
@srirambv
Copy link
Collaborator

Drag and drop arrow sometimes allow to claim the grant (Please watch the full recording its at the end)
captcha arrow

@LaurenWags
Copy link
Member

Able to reproduce #14274 (comment) on macOS.

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 30, 2018
@NejcZdovc
Removes drag from arrow
ddf6085 
Resolves brave#14274

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue May 30, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 30, 2018
@NejcZdovc
Removes drag from arrow
787e8d7 
Resolves brave#14274

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue May 30, 2018
@NejcZdovc
Merge pull request #14277 from NejcZdovc/fix/#14274-arrow
b68fba6 
Removes drag from arrow
NejcZdovc added a commit that referenced this issue May 30, 2018
@NejcZdovc
Merge pull request #14277 from NejcZdovc/fix/#14274-arrow
3d99280 
Removes drag from arrow
NejcZdovc added a commit that referenced this issue May 30, 2018
@NejcZdovc
Merge pull request #14277 from NejcZdovc/fix/#14274-arrow
dba03ff 
Removes drag from arrow
This was referenced May 31, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented May 31, 2018 •
edited
Loading

drag arrow

Still an issue on Windows. Really hard to drag and drop on the target because of the arrow is also dragged.

@srirambv srirambv reopened this May 31, 2018
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 1, 2018 •
edited
Loading

@srirambv can't reproduce it on windows, can you please try with the latest build

Brave: 0.22.725 
V8: 6.6.346.32 
rev: e6dd17f1f9a6bf52dfcee059d6dac3f92197849b 
Muon: 6.0.12 
OS Release: 10.0.16299 
Update Channel: Release 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 66.0.3359.170

@GeetaSarvadnya
Copy link
Collaborator Author

GeetaSarvadnya commented Jun 1, 2018 •
edited by kjozwiak
Loading

@NejcZdovc @srirambv Retested on new build, Issue fixed now on 725 build.

Verified with Windows 10 x64 using

  • 0.22.725 e6dd17f
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

Verified with macOS 10.12.6 using

  • 0.22.725 e6dd17f
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

Verified on Ubuntu 18.04 x64 using the following build:

  • 0.22.725 e6dd17f
  • muon: 6.0.12
  • libchromiumcontent: 66.0.3359.170

@NejcZdovc
Copy link
Contributor

closing issue based on @GeetaSarvadnya comment

@srirambv srirambv mentioned this issue Jun 1, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.22.x Release 5 (Release channel)
Development

No branches or pull requests
6 participants
@kjozwiak @NejcZdovc @bradleyrichter @srirambv @LaurenWags @GeetaSarvadnya