webrequest filtering functions not working in Tor mode

[diracdeltas]

STR:

1. open tor tab
2. go to nytimes.com
3. notice that no ads are blocked in the shields panel

It looks like the partition is initialized, but the webrequest listeners in the Tor session do not fire.

cc @darkdh @riastradh-brave

[lukemulks]

Was testing on Windows 10 - observed some behavior worth noting in case it helps with this.

I began browsing with scripts disabled to get a feel for the edges between ads and no ads with the Tor connection, and observed a tracking pixel being blocked with scripts disabled. Details and STR below.

profile:

Brave: 0.23.2
V8: 6.6.346.26
rev: c09cbf6
Muon: 6.1.0
OS Release: 10.0.16299
Update Channel: Developer
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 66.0.3359.139

STR:

• open tor tab
• once connected, go to https://www.techwalla.com
• click on the site-level shield settings, disable scripts
• reload
• navigate to: https://www.techwalla.com/tablets, or any other subpage within the parent domain.
• observe quantserve tracking being blocked in shield menu.

 Quantserve tracking request (blocked) https://pixel.quantserve.com/pixel/p-4dIM5nVs2rFio.gif

I re-enabled scripts and reloaded the page. I observed what appears to be a mix of ad and tracking calls blocked on that page (scripts re-enabled):

I navigated to the homepage, and observed ad and tracking requests being blocked on the homepage with scripts enabled:

When I attempted to repro the same way from a separate Tor tab (same str as listed above) - I'm observing different results, zero requests blocked across all shield stats.

Note: I tested from this tab without a new Tor circuit, and with, and observe the same result.

I navigated to an article page from the same tab that showed zero blocking and did not observe any blocked ads or tracking from an article page.

Note that I have site isolation enabled in this build as well.

Not sure why I'm seeing different results from the same steps to repro in different Tor tabs, but fwiw did not recall observing tracking protection working until after I began disabling scripts for the tor tab that began blocking things.

[darkdh]

fixed by brave/muon@750df85 which will be available in muon 6.1.1

[btlechowski]

Verified on Ubuntu 17.10 x64

• 0.23.8 06c657b
• Muon 6.1.5
• libchromiumcontent 66.0.3359.181

Verified on Windows 10 x64
• 0.23.8 06c657b
• Muon 6.1.5
• libchromiumcontent 66.0.3359.181

[srirambv]

Verified on Windows 10 x64 using

• 0.23.12 - 88f6f07
• Muon - 7.1.1
• libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

• 0.23.14 f4da855
• Muon 7.1.1
• libchromiumcontent 67.0.3396.87

Verified on Ubuntu 17.10 x64

• 0.23.14 - f4da855
• Muon - 7.1.1
• libchromiumcontent - 67.0.3396.87