Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

textbox not large enough to display large balances #12220

Closed
kjozwiak opened this issue Dec 7, 2017 · 4 comments
Closed

textbox not large enough to display large balances #12220

kjozwiak opened this issue Dec 7, 2017 · 4 comments
Assignees
Labels
0.19.x issue first seen in 0.19.x bug feature/rewards priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Dec 7, 2017

Test Plan

#13744

Description

@darkdh noticed that the textbox under about:preferences#payments isn't big enough for larger balances. We'll either need to make the textbox longer or come up with a better solution for displaying balances.

Steps to Reproduce

N/A... Simply have a wallet with a large balance and you'll notice the issue happening under about:preferences#payments.

Actual result:

example

Expected result:

The entire balance should be visible under about:preferences#payments.

Reproduces how often:

100% reproducible if the user has a large balance.

Brave Version

about:brave info:

Brave: 0.19.105
rev: 51f8ba5
Muon: 4.5.16
libchromiumcontent: 62.0.3202.94

Reproducible on current live release:

Yes, reproducible using 0.19.105 which is the current released version.

@kjozwiak kjozwiak added 0.19.x issue first seen in 0.19.x bug feature/rewards labels Dec 7, 2017
@kjozwiak kjozwiak added this to the Triage Backlog milestone Dec 7, 2017
@bsclifton bsclifton added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Dec 8, 2017
@bsclifton bsclifton modified the milestones: Triage Backlog, Backlog (Prioritized) Dec 8, 2017
@NejcZdovc
Copy link
Contributor

@bradleyrichter what should we do here?

@NejcZdovc NejcZdovc added the needs-mockup A feature which needs design mockup to be implemented. label Jan 16, 2018
@bradleyrichter
Copy link
Contributor

bradleyrichter commented Jan 17, 2018 via email

@NejcZdovc NejcZdovc removed the needs-mockup A feature which needs design mockup to be implemented. label Jan 17, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 5, 2018
Resolves brave#12220

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Apr 23, 2018
NejcZdovc added a commit that referenced this issue Apr 23, 2018
NejcZdovc added a commit that referenced this issue Apr 23, 2018
@NejcZdovc NejcZdovc modified the milestones: Backlog (Prioritized), 0.22.x Release 3 (Beta channel) Apr 23, 2018
@kjozwiak
Copy link
Member Author

kjozwiak commented May 8, 2018

Example of the original issue under 0.22.669 using a staging wallet with 1000 BAT tokens:

screen shot 2018-05-08 at 4 36 12 pm

Example when using 0.22.703 with the same wallet as mentioned above:

screen shot 2018-05-08 at 4 33 37 pm

@kjozwiak
Copy link
Member Author

kjozwiak commented May 8, 2018

Verified on macOS 10.13.3 x64 using the following build:

  • 0.22.703 903b8d0
  • libchromiumcontent: 66.0.3359.139
  • Muon: 6.0.8

Verified on Windows x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

Verified on Ubuntu 17.10 x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.19.x issue first seen in 0.19.x bug feature/rewards priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Development

No branches or pull requests

7 participants