Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remember decision in notification bar doesn't get stored #10391

Closed
srirambv opened this issue Aug 10, 2017 · 0 comments · Fixed by #10407
Closed

Remember decision in notification bar doesn't get stored #10391

srirambv opened this issue Aug 10, 2017 · 0 comments · Fixed by #10407

Comments

@srirambv
Copy link
Collaborator

srirambv commented Aug 10, 2017

Test plan

#10407 (comment)


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Remember decision doesn't get saved

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):

Brave 0.18.21
rev 263b6d5
Muon 4.3.9
  • Steps to reproduce:

    1. Build from 263b6d5
    2. Visit google.com in a tab, select remember this decision and click deny
    3. Close tab and open a new tab and visit google, notification bar shows to see location
    4. Site settings under security has an entry for google to deny access to location
  • Actual result:
    Remember decision in notification bar doesn't get stored

  • Expected result:
    Should not show once a decision is made and remember the decision is selected

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
    Also reported on https://community.brave.com/t/remember-this-decision-not-working/5559

@srirambv srirambv added this to the 0.18.x Hotfix milestone Aug 10, 2017
@diracdeltas diracdeltas self-assigned this Aug 10, 2017
diracdeltas added a commit that referenced this issue Aug 10, 2017
Fix #10391

Test Plan:
1. go to google.com
2. click 'remember this decision' and 'deny' when it asks for your location
3. close tab, open google.com again. it should not ask to see your location.
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
Fix brave#10391

Test Plan:
1. go to google.com
2. click 'remember this decision' and 'deny' when it asks for your location
3. close tab, open google.com again. it should not ask to see your location.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.