Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update extensionsTab.js to our modified BEM style #10207

Closed
luixxiul opened this issue Jul 30, 2017 · 0 comments
Closed

Update extensionsTab.js to our modified BEM style #10207

luixxiul opened this issue Jul 30, 2017 · 0 comments
Assignees
@luixxiul
Labels
feature/about-pages polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 30, 2017 •
edited
Loading

Test plan

#10208 (comment)

Describe the issue you encountered: Update extensionsTab.js to BEM style (ref: https://github.com/brave/browser-laptop/blob/master/docs/style.md#defining-our-blocks-elements-and-modifiers).

  • Platform (Win7, 8, 10? macOS? Linux distro?): All

  • Brave Version (revision SHA): master branch

  • Extra QA steps:

    1. Open about:preferences#extensions
    2. Make sure the table is properly displayed
    3. Scroll the page to the bottom
    4. Make sure the information div has margin-bottom: 40px

  • Any related issues: Fix BEM naming on enabledContent.js #10146
@luixxiul luixxiul added feature/about-pages polish Nice to have — usually related to front-end/visual tasks. refactoring/aphrodite labels Jul 30, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Jul 30, 2017
@luixxiul luixxiul self-assigned this Jul 30, 2017
@luixxiul luixxiul mentioned this issue Jul 30, 2017
Merged
8 tasks
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@dfperry5
Update extensionsTab to the modified BEM style
20f7b49 
Also:
- Remove flex from the top container as displaying the footer on the bottom is inconsistent compared with the other tabs

Closes brave#10207

Test Plan:
1. Open `about:preferences#extensions`
2. Make sure the table is properly displayed
3. Scroll the page to the bottom
4. Make sure the information div has `margin-bottom: 40px`
@luixxiul luixxiul changed the title Update extensionsTab.js to BEM style Update extensionsTab.js to our modified BEM style Sep 11, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/about-pages polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
4 participants
@bbondy @luixxiul @srirambv @LaurenWags