Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Only set active tab when value changes
Browse files Browse the repository at this point in the history
Fix #6791

Auditors: @bridiver

I think the real raeson this is happening is because of the async updating which we'll be removing, but is too risky to do for 0.13.0.

I think this is probably better to do in general though anyway
  • Loading branch information
bbondy committed Jan 21, 2017
1 parent 40dffe8 commit d4f79be
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion js/components/frame.js
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,9 @@ class Frame extends ImmutableComponent {
if (this.webRTCPolicy !== this.getWebRTCPolicy()) {
this.webview.setWebRTCIPHandlingPolicy(this.getWebRTCPolicy())
}
this.webview.setActive(this.props.isActive)
if (prevProps.isActive !== this.props.isActive) {
this.webview.setActive(this.props.isActive)
}
this.webview.setTabIndex(this.props.tabIndex)
this.handleShortcut()

Expand Down

0 comments on commit d4f79be

Please sign in to comment.