Merge pull request #15194 from brave/fix/15162

Fix about:blank appearing on new tab in new windows
brave · Sep 13, 2018 · c5dd2a9 · c5dd2a9
1 parent babc861
commit c5dd2a9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/js/lib/urlutil.js b/js/lib/urlutil.js
@@ -429,7 +429,7 @@ const UrlUtil = {
    */
   openableByContextMenu: function (url) {
     if (!url) {
-      return false
+      return true
     }
     const protocol = urlParse(url).protocol
     // file: is untrusted but handled in a separate check

diff --git a/test/unit/lib/urlutilTestComponents.js b/test/unit/lib/urlutilTestComponents.js
@@ -341,6 +341,9 @@ module.exports = {
       },
       'is about:blank': (test) => {
         test.equal(urlUtil().openableByContextMenu('about:blank'), true)
+      },
+      'is empty': (test) => {
+        test.equal(urlUtil().openableByContextMenu(), true)
       }
     },
     'returns false when input:': {
@@ -349,9 +352,6 @@ module.exports = {
       },
       'is ssh:': (test) => {
         test.equal(urlUtil().openableByContextMenu('ssh://[email protected]'), false)
-      },
-      'is null': (test) => {
-        test.equal(urlUtil().openableByContextMenu(null), false)
       }
     }
   },