This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 971
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor buttons on about:preferences#payments (part 2)
- Removed redundant classes from bookmarkButtons to fix the size difference between "Remove" and "Done" buttons, which was introduced with the commit 85e428a - Introduced new classes "removeButton" and "doneButton" inside bookmarkButtons to make the width of the row same as the other rows - Introduced a new class "copyButton" to keep the font-size of the recovery key copy buttons to 14px - Indroduced a flexbox to copyKeyContainer to keep the buttons aligned Auditors: @bradleyrichter Test Plan: 1. Click the bookmark button on the URL bar 2. Make sure height of "Remove" and "Done" buttons is equal 3. Make sure "Remove" button is longer than "Done" button 4. Make sure color of "Remove" label is no longer white on hover 5. Make sure width of the row of the buttons is equal to the other rows 6. Open about:bookmarks and edit a bookmark 7. Make sure height and width of "Remove" and "Done" are equal 8. Open about:preferences#payments, click Advanced Settings and Backup your wallet 9. Make sure keys and buttons are aligned 10. Make sure font-size of the labels "Copy" is 14px
- Loading branch information
Suguru Hirahara
committed
Nov 22, 2016
1 parent
75a754a
commit 23207ed
Showing
6 changed files
with
25 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23207ed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For QA:
3. Make sure "Remove" button is longer than "Done" button
of 23207edwill beis no longer necessary after #6000 is merged.