Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BraveVPN for Windows/macOS/Android 5% (production) #535

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Mar 7, 2023

Enable BraveVPN feature on Windows, macOS, and Android (brave://flags/#brave-vpn)

Enables for 5% of folks using PRODUCTION brave-variation servers

Addresses brave/brave-browser#25680

@bsclifton bsclifton requested a review from a team as a code owner March 7, 2023 23:30
@bsclifton bsclifton self-assigned this Mar 7, 2023
@bsclifton bsclifton changed the title Enable BraveVPN for Windows/macOS 5% (production) Enable BraveVPN for Windows/macOS/Android 5% (production) Mar 7, 2023
@bsclifton bsclifton force-pushed the bsc-desktop-vpn-prod branch from 30eb7da to 766f6e6 Compare March 8, 2023 00:09
@bsclifton
Copy link
Member Author

NOTE: should be merged AFTER #536

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production approved after deliberating with @brave/uplift-approvers. QA has verified the PR on main (staging) as per #457 (comment), #457 (comment), https://github.com/brave/brave-variations/pull/457#issuecomment-1462892777https://github.com/brave/brave-variations/pull/457#issuecomment-1463921918.

@kjozwiak kjozwiak merged commit 3e4a0fc into production Mar 13, 2023
@kjozwiak kjozwiak deleted the bsc-desktop-vpn-prod branch March 13, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants