-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iOS new menu study for Nightly/Beta #1291
Conversation
✅ Test Seed Generated SuccessfullyTo apply the test seed:
Seed Details
|
@kylehickinson once we run through channel migrations, I'll run through the above and will get the above study pushed into |
|
Example |
Example |
Example |
Example |
---|---|---|---|
BETA
- NewiOSMenuUIStudy:Enabled
(Tablet)
Verification PASSED on iPad Air (3rd Gen)
running iOS 18.1.1
using the following build(s):
Brave | 1.76.5 Chromium: 132.0.6834.83 (Official Build) nightly (64-bit)
---- | ----
Revision | 68c952ae1cbc...
OS | iOS
- launched
1.76.5 Chromium: 132.0.6834.83
and ensured that the old menu is being used - set
Variations PR
to1291
viaBraveCore Switches
under theQA Developer Options
- once
Variations PR
has been set, restarted1.76.5 Chromium: 132.0.6834.83
- restarted
1.76.5 Chromium: 132.0.6834.83
once more - ensured that
pull/1291@732d8e499e6f32457b620a8b2851151897530ed9
viabrave://version
underActive variations
- ensured that
NewiOSMenuUIStudy:Enabled
viabrave://version
- ensured that the new
Hamburger Menu
is being used/visible
Example |
Example |
Example |
Example |
---|---|---|---|
Release
- NewiOSMenuUIStudy
(should be used/appear)
Verification PASSED on iPhone 11
running iOS 18.1.1
using the following build(s):
Brave | 1.73.97 Chromium: 131.0.6778.108 (Official Build) stable (64-bit)
--- | ---
Revision | 7e1cc6e3239d...
OS | iOS
- launched
1.73.97 Chromium: 131.0.6778.108
and ensured that the old menu is being used - set
Variations PR
to1291
viaBraveCore Switches
under theQA Developer Options
- once
Variations PR
has been set, restarted1.73.97 Chromium: 131.0.6778.108
- restarted
1.73.97 Chromium: 131.0.6778.108
once more - ensured that
pull/1291@732d8e499e6f32457b620a8b2851151897530ed9
viabrave://version
underActive variations
- ensured that
NewiOSMenuUIStudy
is not being applied viabrave://version
- ensured that the older menu is still being used
Example |
Example |
Example |
---|---|---|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into main/production
approved after deliberating with @brave/uplift-approvers. QA has verified the above Griffin study on Nightly
& BETA
via #1291 (comment). QA has also verified the feature via 1.75.x
as per brave/brave-browser#42836 (comment) & brave/brave-browser#42836 (comment).
Related issue: brave/brave-browser#42836
Only actually in nightly at the moment but would like to have it available in beta once channel migration occurs