Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS new menu study for Nightly/Beta #1291

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Add iOS new menu study for Nightly/Beta #1291

merged 1 commit into from
Jan 13, 2025

Conversation

kylehickinson
Copy link
Collaborator

Related issue: brave/brave-browser#42836

Only actually in nightly at the moment but would like to have it available in beta once channel migration occurs

@kylehickinson kylehickinson requested a review from a team as a code owner January 7, 2025 17:44
Copy link
Contributor

github-actions bot commented Jan 7, 2025

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1291.
    Android: Set the command line to --variations-pr=1291 in debug menu, restart the browser.
    iOS: Set Variations PR to 1291 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1291@732d8e499e6f32457b620a8b2851151897530ed9
Uploaded Tue, 07 Jan 2025 17:45:18 GMT
PR commit 3d087f1
Base commit a57acce
Merge commit 732d8e4
Serial number f3d6469dd1a7752a56c7eb7bad1779a7

@kjozwiak
Copy link
Member

kjozwiak commented Jan 7, 2025

Related issue: brave/brave-browser#42836

Only actually in nightly at the moment but would like to have it available in beta once channel migration occurs

@kylehickinson once we run through channel migrations, I'll run through the above and will get the above study pushed into production 👍

@kjozwiak
Copy link
Member

Quick Note: The following basically runs through the Griffin study to ensure that it's being applied/working as expected. The actual feature/new menu was tested/verified by QA via brave/brave-browser#42836.

Nightly - NewiOSMenuUIStudy:Enabled (Mobile/Phone)

Verification PASSED on iPhone 11 running iOS 18.1.1 using the following build(s):

Brave | 1.76.5 Chromium: 132.0.6834.83 (Official Build) nightly (64-bit)
---- | ----
Revision | 68c952ae1cbc...
OS | iOS
  • launched 1.76.5 Chromium: 132.0.6834.83 and ensured that the old menu is being used
  • set Variations PR to 1291 via BraveCore Switches under the QA Developer Options
  • once Variations PR has been set, restarted 1.76.5 Chromium: 132.0.6834.83
  • restarted 1.76.5 Chromium: 132.0.6834.83 once more
  • ensured that pull/1291@732d8e499e6f32457b620a8b2851151897530ed9 via brave://version under Active variations
  • ensured that NewiOSMenuUIStudy:Enabled via brave://version
  • ensured that the new Hamburger Menu is being used/visible
Example Example Example Example
IMG_0706 IMG_0707 IMG_0708 IMG_0709

BETA - NewiOSMenuUIStudy:Enabled (Tablet)

Verification PASSED on iPad Air (3rd Gen) running iOS 18.1.1 using the following build(s):

Brave | 1.76.5 Chromium: 132.0.6834.83 (Official Build) nightly (64-bit)
---- | ----
Revision | 68c952ae1cbc...
OS | iOS
  • launched 1.76.5 Chromium: 132.0.6834.83 and ensured that the old menu is being used
  • set Variations PR to 1291 via BraveCore Switches under the QA Developer Options
  • once Variations PR has been set, restarted 1.76.5 Chromium: 132.0.6834.83
  • restarted 1.76.5 Chromium: 132.0.6834.83 once more
  • ensured that pull/1291@732d8e499e6f32457b620a8b2851151897530ed9 via brave://version under Active variations
  • ensured that NewiOSMenuUIStudy:Enabled via brave://version
  • ensured that the new Hamburger Menu is being used/visible
Example Example Example Example
IMG_0499 IMG_0500 IMG_0501 IMG_0502

Release - NewiOSMenuUIStudy (should be used/appear)

Verification PASSED on iPhone 11 running iOS 18.1.1 using the following build(s):

Brave | 1.73.97 Chromium: 131.0.6778.108 (Official Build) stable (64-bit)
--- | ---
Revision | 7e1cc6e3239d...
OS | iOS
  • launched 1.73.97 Chromium: 131.0.6778.108 and ensured that the old menu is being used
  • set Variations PR to 1291 via BraveCore Switches under the QA Developer Options
  • once Variations PR has been set, restarted 1.73.97 Chromium: 131.0.6778.108
  • restarted 1.73.97 Chromium: 131.0.6778.108 once more
  • ensured that pull/1291@732d8e499e6f32457b620a8b2851151897530ed9 via brave://version under Active variations
  • ensured that NewiOSMenuUIStudy is not being applied via brave://version
  • ensured that the older menu is still being used
Example Example Example
IMG_0710 IMG_0711 IMG_0712

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into main/production approved after deliberating with @brave/uplift-approvers. QA has verified the above Griffin study on Nightly & BETA via #1291 (comment). QA has also verified the feature via 1.75.x as per brave/brave-browser#42836 (comment) & brave/brave-browser#42836 (comment).

@kjozwiak kjozwiak added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit d4250c5 Jan 13, 2025
6 checks passed
@kjozwiak kjozwiak deleted the ios-new-menu branch January 13, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants