-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled brave search promotion button study for CA/GB in beta/nightly #1275
Conversation
✅ Test Seed Generated SuccessfullyTo apply the test seed:
Seed Details
|
5c81340
to
1ac0533
Compare
also remove CA/GB from search promotion banner study.
1ac0533
to
4fe12b9
Compare
|
`Example | Example |
Example |
---|---|---|
BETA
verification:
Test Case #2
- BraveSearchPromotionButtonStudy:Enabled
(Using GB
- UK/Great Britian)
Verification PASSED on Win 11 Pro x64
using the following build(s):
Brave | 1.75.161 Chromium: 132.0.6834.83 (Official Build) beta (64-bit)
-- | --
Revision | 7e59e37e24ad33062e0f20e842236aa03f579407
OS | Windows 11 Version 24H2 (Build 26100.2605)
- launched
1.75.161 Chromium: 132.0.6834.83
using the followingbrave.exe --enable-logging=stderr --variations-pr=1275 --variations-override-country=gb
Quick Note:
we're using --variations-override-country=gb
due to griffin.brave.com
not supporting x-country
header
- restarted
1.75.161 Chromium: 132.0.6834.83
- ensured
pull/1275@783ce3e2f737f54091ef23b0f4abc7e33b6418f1
viabrave://version
- ensured that
BraveSearchPromotionButtonStudy:Enabled
was appearing underbrave://version
- change the default SE from
Brave
->DDG
viabrave://settings/search
- ensure that the
Brave
promotional banner is being displayed via theomnibox
when typing a search term
`Example | Example |
Example |
---|---|---|
Test Case #3
- BraveSearchPromotionButtonStudy
NOT meeting country
(Using PL
- Poland)
- launched
1.75.161 Chromium: 132.0.6834.83
using the followingbrave.exe --enable-logging=stderr --variations-pr=1275 --variations-override-country=pl
Quick Note:
we're using --variations-override-country=pl
due to griffin.brave.com
not supporting x-country
header
- restarted
1.75.161 Chromium: 132.0.6834.83
- ensured
pull/1275@783ce3e2f737f54091ef23b0f4abc7e33b6418f1
viabrave://version
- ensured that
BraveSearchPromotionButtonStudy
is NOT appearing/being used underbrave://version
- due to
country
not being eitherCA
orGB
- due to
- change the default SE from
Brave
->DDG
viabrave://settings/search
- ensure that the
Brave
promotional banner is NOT being displayed via theomnibox
when typing a search term
`Example | Example |
Example |
Example |
---|---|---|---|
Release
verification:
Test Case #4
- BraveSearchPromotionButtonStudy
NOT used (Using CA
)
Verification PASSED on Win 11 Pro x64
using the following build(s):
Brave | 1.74.48 Chromium: 132.0.6834.83 (Official Build) (64-bit)
-- | --
Revision | abcdb1e011a32c5baf82019bf0b537c22baeb92d
OS | Windows 11 Version 24H2 (Build 26100.2605)
- launched
1.74.48 Chromium: 132.0.6834.83
using the followingbrave.exe --enable-logging=stderr --variations-pr=1275 --variations-override-country=ca
Quick Note:
we're using --variations-override-country=ca
due to griffin.brave.com
not supporting x-country
header
- restarted
1.74.48 Chromium: 132.0.6834.83
- ensured
pull/1275@783ce3e2f737f54091ef23b0f4abc7e33b6418f1
viabrave://version
- ensured that
BraveSearchPromotionButtonStudy
is NOT appearing/being used underbrave://version
- change the default SE from
Brave
->DDG
viabrave://settings/search
- ensure that the
Brave
promotional banner is NOT being displayed/used
`Example | Example |
Example |
Example |
---|---|---|---|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into main/production
approved 👍 QA has verified that the Griffin study is working as expected on Nightly
, BETA
& Release
as per #1275 (comment). QA also verified the feature as per brave/brave-browser#40776.
Related issue - brave/brave-browser#40776
also removed CA/GB from search promotion banner study.