Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DayZeroStudy for android in release channel #1258

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

deeppandya
Copy link
Contributor

We need to add DayZeroStudy to A/B test new onboarding changes here : brave/brave-core#26193

@deeppandya deeppandya self-assigned this Nov 7, 2024
@deeppandya deeppandya requested a review from a team as a code owner November 7, 2024 20:41
Copy link
Contributor

github-actions bot commented Nov 7, 2024

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1258.
    Android: Set the command line to --variations-pr=1258 in debug menu, restart the browser.
    iOS: Set Variations PR to 1258 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1258@93f2b0bfd08bafc2b81a5eb9fbdf4ae63e7c65fe
Uploaded Fri, 22 Nov 2024 21:36:59 GMT
PR commit 1403dfb
Base commit 84348c2
Merge commit 93f2b0b
Serial number c444ddff7edd4b48a7ebb58452a969df

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into main/production approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 5c9fcab Nov 25, 2024
6 checks passed
@kjozwiak kjozwiak deleted the day_zero_android branch November 25, 2024 21:23
@kjozwiak
Copy link
Member

kjozwiak commented Nov 25, 2024

Android verification(s):

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.73.91 Chromium: 131.0.6778.85 (Official Build) (64-bit)
--- | ---
Revision | 35427fa72a008a7e861fa9828e07a0ba2cd46ebd
OS | Android 15; Build/AP41.240925.009; 35; REL

Release - DayZeroStudyAndroid:Default

  • launched 1.73.91 Chromium: 131.0.6778.85
  • ensured that pull/1258@93f2b0bfd08bafc2b81a5eb9fbdf4ae63e7c65fe via brave://version under Active variations
  • ensured that DayZeroStudyAndroid:Default via brave://version
  • ensured that the current onboard experience is being used
    • Brave animation at the start when the application is launched
    • Notification permission at the beginning of onboarding
    • default browser modal with a Set as default browser button that displays the system modal
    • P3A/Stats
Example Example Example Example
Screenshot_20241125-172810 1000002347 1000002348 1000002349

Release - DayZeroStudyAndroid:EnabledA

  • launched 1.73.91 Chromium: 131.0.6778.85
  • ensured that pull/1258@93f2b0bfd08bafc2b81a5eb9fbdf4ae63e7c65fe via brave://version under Active variations
  • ensured that DayZeroStudyAndroid:EnabledA via brave://version
  • ensured that the new onboard experience is being used
    • Brave animation at the start when the application is launched
    • Notification permission has been removed and is triggered when interacting with a feature that needs permissions
    • Set as default browser screen was removed and the default browser system modal is shown instead
    • P3A/Stats
Example Example Example
Screenshot_20241126-002045 Screenshot_20241126-001933 Screenshot_20241126-001937

Release - DayZeroStudyAndroid:EnabledB

  • launched 1.73.91 Chromium: 131.0.6778.85
  • ensured that pull/1258@93f2b0bfd08bafc2b81a5eb9fbdf4ae63e7c65fe via brave://version under Active variations
  • ensured that DayZeroStudyAndroid:EnabledB via brave://version
  • ensured that the current onboard experience is being used
    • Brave animation at the start when the application is launched
    • Notification permission at the beginning of onboarding
    • default browser modal with a Set as default browser button that displays the system modal
    • P3A/Stats
Example Example Example Example
Screenshot_20241125-232153 1000002347 1000002348 1000002349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants