Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8191: Improve memory usage of compiling ad-block engines #8193

Closed
wants to merge 10 commits into from
Closed

Fix #8191: Improve memory usage of compiling ad-block engines #8193

wants to merge 10 commits into from

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Oct 4, 2023 •
edited
Loading

Summary of Changes

This pull request fixes #8191

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

see issue for STR

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@cuba cuba force-pushed the js/test-engine-tool branch 2 times, most recently from a9261e6 to 27d1117 Compare October 6, 2023 17:41
@cuba cuba changed the title Add a test engines tool Improve memory usage of compiling ad-block engines Oct 6, 2023
@cuba cuba force-pushed the js/test-engine-tool branch 3 times, most recently from 65de259 to 1e7915d Compare October 6, 2023 18:10
@cuba cuba force-pushed the js/test-engine-tool branch from 1e7915d to af634e3 Compare October 6, 2023 18:49
@cuba cuba force-pushed the js/test-engine-tool branch 7 times, most recently from 619c52e to ab0a145 Compare October 8, 2023 05:42
@cuba cuba force-pushed the js/test-engine-tool branch from ab0a145 to 92a9b30 Compare October 10, 2023 20:26
@cuba cuba force-pushed the js/test-engine-tool branch from 92a9b30 to 3e0f6c3 Compare October 10, 2023 23:59
@cuba cuba marked this pull request as ready for review October 11, 2023 15:47
@cuba cuba requested a review from a team as a code owner October 11, 2023 15:47
@iccub iccub changed the title Improve memory usage of compiling ad-block engines Fix #8191: Improve memory usage of compiling ad-block engines Oct 11, 2023
@cuba cuba force-pushed the js/test-engine-tool branch from 3e0f6c3 to 5a91687 Compare October 11, 2023 16:33
@cuba
Copy link
Contributor Author

cuba commented Oct 11, 2023

I will close this and reopen without logging and test view and some other fixes as PRs opened separately

@cuba cuba closed this Oct 11, 2023
@cuba
Copy link
Contributor Author

cuba commented Oct 11, 2023

Moved here: #8224

@cuba cuba mentioned this pull request Nov 1, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adblock crash
1 participant
@cuba