Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8087: VPN Reset Configuration Clear confirmation #8122

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Sep 21, 2023

Summary of Changes

This pull request fixes #8087

An alert is added for confirmation success case
Additionally color fix for profile add screen

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Launch Brave
  • Three-dot menu > VPN
  • Buy a subscription and Install VPN profile
  • Three-dot menu > Settings > Brave Firewall + VPN
  • Reset Configuration > Reset > Observe

Screenshots:

test121 11

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel requested a review from a team as a code owner September 21, 2023 21:17
@soner-yuksel soner-yuksel self-assigned this Sep 21, 2023
@soner-yuksel soner-yuksel enabled auto-merge (squash) September 21, 2023 21:17
@iccub iccub added this to the 1.59 milestone Sep 25, 2023
@soner-yuksel soner-yuksel merged commit 37e31a6 into development Sep 25, 2023
@soner-yuksel soner-yuksel deleted the fix/vpn-reset-success branch September 25, 2023 13:35
@soner-yuksel soner-yuksel added QA/Yes and removed QA/Yes labels Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPN Reset Configuration doesn't have a clear confirmation if the reset was done already
2 participants