Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8076: Bump BraveCore to v1.59.x #8077

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Fix #8076: Bump BraveCore to v1.59.x #8077

merged 3 commits into from
Sep 19, 2023

Conversation

StephenHeaps
Copy link
Contributor

Summary of Changes

  • Bump BraveCore to v1.59.84

This pull request fixes #8076

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

StephenHeaps and others added 3 commits September 18, 2023 09:50
@StephenHeaps
Update BraveCore to v1.59.41
098c8d9
@StephenHeaps
[v1.59] Fix #7866: AccountId Transaction Refactor, BraveCore v1.59.59 (…
5dc3a69 
…#7997)

* Update BraveCore to v1.59.44. Apply AccountId for Transaction refactor updates.

* Update BraveCore to v1.59.59

* Disable failing `testCompilationofResources` test.
@nuo-xu @StephenHeaps
upgrade brave core to 1.59.84
01cf75c
@StephenHeaps StephenHeaps added this to the 1.59 milestone Sep 18, 2023
@StephenHeaps StephenHeaps requested a review from a team as a code owner September 18, 2023 14:00
soner-yuksel
soner-yuksel approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@soner-yuksel soner-yuksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@StephenHeaps StephenHeaps merged commit feccfd7 into development Sep 19, 2023
@StephenHeaps StephenHeaps deleted the brave-core-1.59.x branch September 19, 2023 19:56
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@StephenHeaps @nuo-xu
Fix brave/brave-ios#8076: Bump BraveCore to v1.59.x (brave/brave-ios#…
261c511 
…8077)

* Update BraveCore to v1.59.41

* [v1.59] Fix brave/brave-ios#7866: AccountId Transaction Refactor, BraveCore v1.59.59 (brave/brave-ios#7997)

* Update BraveCore to v1.59.44. Apply AccountId for Transaction refactor updates.

* Update BraveCore to v1.59.59

* Disable failing `testCompilationofResources` test.

* upgrade brave core to 1.59.84

---------

Co-authored-by: Nuo Xu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

@soner-yuksel soner-yuksel soner-yuksel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.60
Development

Successfully merging this pull request may close these issues.

Bump Brave Core to 1.59.x
4 participants
@StephenHeaps @soner-yuksel @iccub @nuo-xu