Implement Logins & Password Screens

[soner-yuksel]

Problem Description

The iOS Browser should have screen where Passwords & Logins can be viewed and interacted. This controller should include list of saved logins, and also actions like edit, delete and search etc.

Feature Overview

The Passwords & Logins feature will contain a new security menu item for Passwords & Logins. The item will represent user the list of password being saved and provide some functionality over the list like deleting and searching. Every password & login item will redirect to a detail screen where user can update, delete and do some actions like fill & open.

Design

Implementation Details

First Part List Screen:

• A new entry point will be added in Settings under Security Section for Logins & Passwords.
• The controller will present the a search bar for filtering the login items for username and hostname (website)
• Saved Logins toggle and Show in Application Menu toggle will be places in list screen.
• The saved login items will be displayed in list style and favicon, hostname and account name will also be displayed in every row.
• There will be edit table functionality where we can activate edit mode for the list view and in addition swipe to delete items will be supported.
• A alert will prompted when user wants to delete an login item for approval.

Second Part Detail Screen:

• Detail screen will include information showing Website, Username, Password, Created Date.
• The password will be shown in secure mode until edit is activated and there will be delete button that will be prompting the alert for deleting the actual login & password item.
• The edit mode will activate username as the responder and return item for the keyboard will be next.
• Selecting password item will show the password and changing the responder to a separate field should re-active secure field.
• Pressing done either on navigation bar or in keyboard to end editing will save the changes.
• Delete button will work same way in lis screen which will propmt a alert and if okay is selected it will delete the item and navigate list screen.
• Website, Name and Password rows will have a click actions when it is table is not in edit mode. these actions will vary which item is clicked on.

User Experience

1. Navigate to Settings and security section Logins & Password menu item will be present
2. Clicking this menu item will present the password list screen described above
3. Filtering/Searching can be activated by clicking the search field
4. Any item can be deleted using swipe to delete or by pressing the edit mode in navigation bar
5. Enabling Saved Logins Toggle will activate the existing save login functionality like before
6. Enabling Show in Application Menu toggle will add Passwords as a menu item under directly under application for easy accessing like History Bookmarks etc
7. Clicking any password item will open up details about the login item
8. Editing can be enabled by clicking the edit button on navigation bar
9. After deleting any item, the view for listing the passwords will be navigated automatically.
10. Website, Username and Password item will have click action when the list is not in edit mode. Website row will have Copy - Open & Fill, Username will have Copy and Password will have Copy and Reveal actions that can be clicked.

Additional information

Also for enhancing the security the password screen will also include blur background when application is not on active display and if browser lock is on the entry to passwords screen will also require Authentication. (This will mimic the password screen implementation of iOS Passwords screen)

Image.from.iOS.2.MP4

When user enabled the Show in Application Menu Toggle, the menu item will be presented in Setting Menu for easy access.

[iccub]

Reopening, code is merged but hidden from UI until we are ready to test it

[soner-yuksel]

The Restore PR is merged #4743.

The feature can be tested with 1.34

[soner-yuksel]

Ability of showing passwords on main settings page is removed along with the Show in Application Menu Toggle in password list screen.

[srirambv]

Verification passed on iPhone 7+ with iOS 14.8.1 running 1.34 (22.1.5.15)

• Verified a new setting is available for Logins & Passwords under Security
• Verified Save Logins is enabled by default
• Verified disabling Save logins doesn't prompt save logins prompt on sites
• Verified selecting Save Login automatically saves the credentials under Logins & Passwords
• Verified opening a saved credentials and clicking on the website brings up popup for Copy and Open & Fill
• Verified selecting Open & Fill loads a new tab and auto-populates the credentials
• Verified visiting a site with saved credentials auto-populates the credentials
• Verified clicking on the username shows popup to copy the username
• Verified clicking on the password filed shows popup for Copy and Reveal
• Verified selecting Reveal shows the password in plain text
• Verified selecting Copy copies username/password to clipboard
• Verified able to delete a credential from details view, list view
• Verified opening a credential shows the date it was saved on
• Verified searching for a credential filters out the matching records
• Verified when no matching result is found shows message No logins found
• Verified when biometric lock for app is enabled, opening Logins & Passwords requests biometric unlock
• Verified password won't autofill on private tabs
• Verified save password is not prompted for private tabs

---

Verification passed on iPhone XR with iOS 15.2 running 1.34 (22.1.5.15)

• Verified a new setting is available for Logins & Passwords under Security
• Verified Save Logins is enabled by default
• Verified disabling Save logins doesn't prompt save logins prompt on sites
• Verified selecting Save Login automatically saves the credentials under Logins & Passwords
• Verified opening a saved credentials and clicking on the website brings up popup for Copy and Open & Fill
• Verified selecting Open & Fill loads a new tab and auto-populates the credentials
• Verified visiting a site with saved credentials auto-populates the credentials
• Verified clicking on the username shows popup to copy the username
• Verified clicking on the password filed shows popup for Copy and Reveal
• Verified selecting Reveal shows the password in plain text
• Verified selecting Copy copies username/password to clipboard
• Verified able to delete a credential from details view, list view
• Verified opening a credential shows the date it was saved on
• Verified searching for a credential filters out the matching records
• Verified when no matching result is found shows message No logins found
• Verified when biometric lock for app is enabled, opening Logins & Passwords requests biometric unlock
• Verified password won't autofill on private tabs
• Verified save password is not prompted for private tabs

---

Verification passed on iPad Pro with iOS 15.3 running 1.34 (22.1.5.15)

• Verified a new setting is available for Logins & Passwords under Security
• Verified Save Logins is enabled by default
• Verified disabling Save logins doesn't prompt save logins prompt on sites
• Verified selecting Save Login automatically saves the credentials under Logins & Passwords
• Verified opening a saved credentials and clicking on the website brings up popup for Copy and Open & Fill
• Verified selecting Open & Fill loads a new tab and auto-populates the credentials
• Verified visiting a site with saved credentials auto-populates the credentials
• Verified clicking on the username shows popup to copy the username
• Verified clicking on the password filed shows popup for Copy and Reveal
• Verified selecting Reveal shows the password in plain text
• Verified selecting Copy copies username/password to clipboard
• Verified able to delete a credential from details view, list view
• Verified opening a credential shows the date it was saved on
• Verified searching for a credential filters out the matching records
• Verified when no matching result is found shows message No logins found
• Verified when biometric lock for app is enabled, opening Logins & Passwords requests biometric unlock
• Verified password won't autofill on private tabs
• Verified save password is not prompted for private tabs

---

Encountered #4814