Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Unable to add publishers to ac list #2954

Closed
srirambv opened this issue Oct 12, 2020 · 1 comment · Fixed by #2960 or #2987
Closed

Unable to add publishers to ac list #2954

srirambv opened this issue Oct 12, 2020 · 1 comment · Fixed by #2960 or #2987
Assignees
@kylehickinson
Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes regression release/blocking release-notes/exclude
Milestone
1.21

Comments

@srirambv
Copy link
Contributor

Description:

Unable to add publishers to ac list

Steps to Reproduce

  1. Clean install 1.21(20.10.9.13)
  2. Enable rewards on staging
  3. Visit a few pubs and stay for min 30 sec on each page,
  4. None of them have been added to the ac list

Actual result:
Unable to add publishers to ac list

Expected result:
Should add pubs to the list as soon as the min time spent is reached

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.21(20.10.09.13)

Device details:
All

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information
@srirambv srirambv added this to the 1.21 milestone Oct 12, 2020
@kylehickinson kylehickinson mentioned this issue Oct 13, 2020
Merged
33 tasks
kylehickinson added a commit that referenced this issue Oct 14, 2020
@kylehickinson
Fix #2959, Fix #2954: Update Rewards lib to fix rewards initializations
b0a55ae
@kylehickinson kylehickinson mentioned this issue Oct 14, 2020
Merged
7 tasks
kylehickinson added a commit that referenced this issue Oct 15, 2020
@kylehickinson
Fix #2959, Fix #2954: Update Rewards lib to fix rewards initializatio…
187176e 
…ns (#2960)
kylehickinson added a commit that referenced this issue Oct 21, 2020
@kylehickinson
Ref #2954: Set required default wallet prefs
84f428d
@kylehickinson kylehickinson mentioned this issue Oct 21, 2020
Merged
7 tasks
iccub pushed a commit that referenced this issue Oct 21, 2020
@kylehickinson
Ref #2954: Set required default wallet prefs (#2987)
0523a39
@srirambv
Copy link
Contributor Author

Verification passed on iPhone 7+ with iOS 14.1 running 1.21(20.10.23.15)

  • Verified pubs are added to ac list

Verification passed on iPhone XR with iOS 13.5 running 1.21(20.10.23.15)

  • Verified pubs are added to ac list

Verification passed on iPad Pro with iOS 12.4.1 running 1.21(20.10.23.15)

  • Verified pubs are added to ac list

Brandon-T pushed a commit that referenced this issue Nov 19, 2020
@kylehickinson @Brandon-T
Fix #2959, Fix #2954: Update Rewards lib to fix rewards initializatio…
df0ef92 
…ns (#2960)
Brandon-T pushed a commit that referenced this issue Nov 19, 2020
@kylehickinson @Brandon-T
Ref #2954: Set required default wallet prefs (#2987)
c0852de
Brandon-T added a commit that referenced this issue Nov 19, 2020
@Brandon-T
Fix #2959, Fix #2954: Update Rewards lib to fix rewards initializatio…
51c58fc 
…ns (#2960)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes regression release/blocking release-notes/exclude
Projects
None yet
Milestone
1.21
2 participants
@kylehickinson @srirambv