This repository has been archived by the owner on Jun 6, 2019. It is now read-only.
Wait until "Block by CSS selector" context menu is clicked to find unique css selector #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a performance issue when right-clicking on a Twitter timeline, this is due to the way Twitter builds it's elements (with dozens of css class names) which impacts the way the library
unique-selector
finds elements. This causes a few seconds delay every time anything on a Twitter timeline is clicked.You can see a bit more details here: https://community.brave.com/t/right-click-hangs-on-mobile-twitter/43332/4
This PR rewrites
app/content.ts
andapp/background/events/cosmeticFilterEvents.ts
so that the actualunique
call only happens after the Context sub menu item is clicked.FYI, I wasn't able to get this changes running locally, so I've wrote this PR blindly – I not 100% sure it's going to work.