Fix Windows link error

[garrettr]

Fixes brave/brave-browser#146.

It's unclear to me why this linker error should only appear on Windows, and not macOS or Linux. I noticed that the static_library target that contains the missing password_manager::LoginDatabase symbols is split into multiple static libraries on Windows builds, but I am not sure if that is the cause.

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.

Test Plan:

On Windows:

1. Checkout this branch in your brave-core subrepo (e.g. brave/src/brave)
2. yarn build in your brave-browser repo

The build should complete successfully.

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions

[bridiver]

@garrettr it's not uncommon to have linking issue that appear on windows, but not other platforms. Sometimes it's because of defined(OS_WIN) guards, but more often it seems that the windows compiler just sucks at dead code elimination

[simonhong]

LGTM

[emerick]

LGTM

[garrettr]

Thanks, @bridiver, that's good to know. In any case I'll be sure to test future PR's across all platforms to avoid this kind of issue.

[bridiver]

@garrettr also after looking at the files in this target, you should be adding deps for any include that you use. chrome_importer.cc should have net, autofill, base, prefs, etc...