Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sidebar show option is not applied properly when it's changed #8878

Merged
merged 1 commit into from
May 20, 2021

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented May 20, 2021

fix brave/brave-browser#15958
When sidebar show option context menu gets visible or hidden,
view's mouse entered/exited callback is called even if mouse is still
in the view. Because of this, newly changed option is not applied
well.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See STR in the issue

@simonhong simonhong self-assigned this May 20, 2021
@simonhong simonhong changed the title WIP: Fixed sidebar show option is not applied properly when it's changed Fixed sidebar show option is not applied properly when it's changed May 20, 2021
@simonhong simonhong marked this pull request as ready for review May 20, 2021 10:57
fix brave/brave-browser#15958
When sidebar show option context menu gets visible or hidden,
view's mouse entered/exited callback is called even if mouse is still
in the view. Because of this, newly changed option is not applied well.
@simonhong simonhong force-pushed the fix_sidebar_show_options branch from 6652e3a to 5d164c4 Compare May 20, 2021 10:58
@simonhong simonhong requested a review from emerick May 20, 2021 10:58
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong
Copy link
Member Author

Merged because only unrelated RewardsNotificationBrowserTest.InsufficientNotificationForACNotEnoughFunds was failed on linux CI. Reported - brave/brave-browser#16013

@simonhong simonhong merged commit ddaa9d3 into master May 20, 2021
@simonhong simonhong deleted the fix_sidebar_show_options branch May 20, 2021 22:55
@simonhong simonhong added this to the 1.27.x - Nightly milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side bar show always doesn't work properly
2 participants