Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In app callout android #7715

Merged
merged 4 commits into from
Jan 27, 2021
Merged

In app callout android #7715

merged 4 commits into from
Jan 27, 2021

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#12209

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please follow the main issue for test plans.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 27, 2021
@deeppandya deeppandya added this to the 1.21.x - Nightly milestone Jan 27, 2021
@deeppandya deeppandya self-assigned this Jan 27, 2021
Update existing shields tooltip
Update behaviour for tooltips
@deeppandya deeppandya force-pushed the in_app_callout_android branch from 1639828 to 169486d Compare January 27, 2021 15:38
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya merged commit 2516c6a into master Jan 27, 2021
@deeppandya deeppandya deleted the in_app_callout_android branch January 27, 2021 17:18
@srirambv
Copy link
Contributor

srirambv commented Feb 3, 2021

Verification passed on OnePlus 6T with Android 10 running 1.21.39 x64 Nightly build

  • Verified in-app callout cars are as per spec

Portrait

Ads Blocked Video Ads blocked 10+ ads/trackers blocked Encrypted connection
image image image image

Landscape

Ads Blocked Video Ads blocked 10+ ads/trackers blocked Encrypted connection
image image image image

deeppandya pushed a commit that referenced this pull request Feb 3, 2021
deeppandya pushed a commit that referenced this pull request Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Educational in-product notification
3 participants