Import passwords from Chrome #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase against master, thx |
added 2 commits
April 2, 2018 17:14
We want to reuse Chrome's code as much as possible when importing encrypted data (e.g. saved passwords, cookies) from a Chrome profile. The encryption is managed by OSCrypt, which has an unfortunate singleton design that makes it difficult to modify its behavior at runtime. This commit uses Muon's approach of using a command line switch as a proxy for a global variable to change the behavior of OSCrypt in the importer helper process.
garrettr
force-pushed
the
import-chrome-passwords
branch
from
2f9b051 to
74fa96c
Compare
|
@darkdh Rebased! |
This was referenced Apr 3, 2018
NejcZdovc
pushed a commit
that referenced
this pull request
Dec 10, 2018
make production/verbose extern
bbondy
added a commit
that referenced
this pull request
Feb 18, 2019
Add sitehacks and cosmetic filters from browser-laptop
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
I spent some time working on automated tests for this branch, but they were complicated by the design of OSCrypt and interactions with the various system keychains. To keep momentum going, I'm posting this branch for review without tests. I think I may be able to get a reasonable unit test working in the near future, which could be included in this PR or a follow-up.
Reviewer Checklist: