Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recalculate auto-contribute table after exclude #752

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Recalculate auto-contribute table after exclude #752

merged 1 commit into from
Oct 29, 2018

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Oct 28, 2018

Fixes brave/brave-browser#1410

Ledger implementation: brave-intl/bat-native-ledger#161

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Start Brave and enable Rewards
  2. Add some sites to auto-contribute
  3. Exclude some sites and verify the percentages are recalculated correctly
  4. Restore excluded publishers and verify the percentages are recalculated correctly

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Updated ledger branch

Update bat-native-ledger dependency
@NejcZdovc NejcZdovc merged commit 804ea39 into brave:master Oct 29, 2018
NejcZdovc added a commit that referenced this pull request Oct 29, 2018
Recalculate auto-contribute table after exclude
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Oct 29, 2018

master 804ea39
0.57.x 5a0cff2
0.56.x 705d423
0.55.x 4b2788d

NejcZdovc added a commit that referenced this pull request Oct 29, 2018
Recalculate auto-contribute table after exclude
NejcZdovc added a commit that referenced this pull request Oct 29, 2018
Recalculate auto-contribute table after exclude
@bbondy
Copy link
Member

bbondy commented Oct 30, 2018

Reverted for hotfix2, so will only be in 0.56.x and beyond.

@jasonrsadler jasonrsadler deleted the visit-exclude-recalc-core branch October 30, 2018 15:06
@bbondy bbondy added this to the 0.56.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave Auto Contribute percentage values do not recalculate after removing sites
3 participants