-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uses of html imports from WebUI #6736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chromium 86 no longer supports html imports, even for WebUI. We were only using it to: 1. Import a polymer component, br-toolbar. This has already been converted to an es module, so we simply include that. 2. Import cr.html which was never neccessary because we also include cr.js already. cr.html only additionally adds the import for PromiseResolver, which no brave code uses. TODO: remove calls to cr.js and just `import * as cr from cr.m.js` directly wherever cr.* is used.
emerick
approved these changes
Sep 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bsclifton
approved these changes
Sep 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too - compiling so I can give it a go (can report back; don't hold up the merge for me)
zenparsing
approved these changes
Sep 30, 2020
Confirmed- works great! 😄 🎉 |
ryanml
approved these changes
Sep 30, 2020
NejcZdovc
approved these changes
Sep 30, 2020
This was referenced Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium 86 no longer supports html imports, even for WebUI. We were only using it to:
TODO: remove calls to cr.js and just
import * as cr from cr.m.js
directly wherever cr.* is used.Fix brave/brave-browser#11937
Submitter Checklist:
npm run lint
,npm run gn_check
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Ensure brave/brave-browser#11937 is resolved. Additionally ensure the following WebUI pages still work correctly:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.