s/antimuon/brave #67
Merged
s/antimuon/brave #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrliou
reviewed
Mar 26, 2018
| @@ -4,7 +4,7 @@ | |||
| import re | |||
| import sys | |||
|
|
|||
| from lib.config import SOURCE_ROOT, get_antimuon_version, get_chrome_version | |||
| from lib.config import SOURCE_ROOT, get_brave_version, get_chrome_version | |||
DEPS
Outdated
| "vendor/ad-block": "https://github.com/brave/ad-block.git@84cbd78e346f8276ec06ca8d1193a01aaf0fc67f", | ||
| "vendor/tracking-protection": "https://github.com/brave/tracking-protection.git@051177425a14121a22087d754ad8eb1c0ce8fb24", | ||
| "vendor/hashset-cpp": "https://github.com/bbondy/hashset-cpp.git@67ffffa69b56e330bab9d08f050727f891c916a1", | ||
| "vendor/bloom-filter-cpp": "https://github.com/bbondy/bloom-filter-cpp.git@d511cf872ea1d650ab8dc4662f6036dac012d197", | ||
| "vendor/brave-extension": "https://github.com/brave/brave-extension.git@38af139dd65ba6a2a6f84cfc40f214080499dbae", |
There was a problem hiding this comment.
You might also want to replace antimuon in https://github.com/brave/brave-extension/blob/master/py-scripts/build-brave-extension.py#L15-L17 and update DEPS here.
| @@ -16,7 +16,7 @@ def main(): | |||
| option = sys.argv[1] | |||
| increments = ['major', 'minor', 'patch'] | |||
| if option in increments: | |||
| version = get_antimuon_version() | |||
| version = get_brave_version() | |||
script/lib/config.py
Outdated
| return version.split('+')[1] | ||
|
|
||
| def get_antimuon_version(): | ||
| version = os.environ.get('npm_config_antimuon_version') or brave_package()['version'] | ||
| def get_brave_core_version(): |
There was a problem hiding this comment.
Some files are using get_brave_version() which seems undefined in this file, and some are using get_brave_core_version(). You may want to change the function name to get_brave_version and use it everywhere in this PR or s/get_brave_version/get_brave_core_version.
|
Nice catch, updated. |
yrliou
approved these changes
Mar 26, 2018
NejcZdovc
added a commit
that referenced
this pull request
Dec 10, 2018
fixed next interval calculation when downloading publishers list
bbondy
pushed a commit
that referenced
this pull request
Feb 18, 2019
Add incognito to the extension manifest and set to split mode
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
updateBranding for create_distr
petemill
pushed a commit
that referenced
this pull request
Jul 27, 2020
updateBranding for create_distr
petemill
pushed a commit
that referenced
this pull request
Jul 28, 2020
updateBranding for create_distr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#120
See also:
brave/brave-browser#121
brave/brave-extension#14