Add tests for static redirect helper #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettr
previously approved these changes
Mar 20, 2018
|
Thanks for the review, I Modiified it;) |
bbondy
force-pushed
the
redirect_delegate
branch
from
462feec to
6d82e05
Compare
bbondy
pushed a commit
that referenced
this pull request
Feb 18, 2019
Handle no active tab in state and no cosmetic filter list in storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple tests to the static redirect helper, which is currently only used to rewrite geolocation api requests to our endpoint.
To test:
./src/out/Release/brave_unit_tests