Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies tip flow from service to shared lib #4870

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 6, 2020

Resolves brave/brave-browser#8403

Submitter Checklist:

Test Plan:

  • enable rewards
  • claim grant
  • do one time tip
  • set recurring tip
  • change recurring tip value in the panel
  • go to rewards page and check if everything is reflected there

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.7.x - Nightly milestone Mar 6, 2020
@NejcZdovc NejcZdovc self-assigned this Mar 6, 2020
@NejcZdovc NejcZdovc force-pushed the recurring-tip branch 4 times, most recently from 1fefc67 to ccbf6b0 Compare March 6, 2020 14:33
@NejcZdovc NejcZdovc marked this pull request as ready for review March 6, 2020 14:59
@NejcZdovc NejcZdovc requested a review from a team March 6, 2020 14:59
@@ -343,6 +341,10 @@ class LEDGER_EXPORT Ledger {

virtual void GetAllContributions(
ledger::ContributionInfoListCallback callback) = 0;

virtual void SavePublisherInfo(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does iOS need to call this for any reason?

Copy link
Contributor Author

@NejcZdovc NejcZdovc Mar 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, it's desktop specific usage

@NejcZdovc NejcZdovc requested a review from a team March 6, 2020 15:18
Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS changes look good!

@NejcZdovc NejcZdovc requested a review from a team March 6, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove recurring flag from DoTip in rewards service in lib
3 participants