Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop caching "originator_cache_guid" and "originator_client_item_id" to #4610

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Feb 12, 2020

prevent generating duplicate tracking entries.
The cached ids are not accurate when receiving remote CREATE and then
committing UPDATE because we never get to propagate the real value to
other devices

Resolves brave/brave-browser#8203

Submitter Checklist:

Test Plan:

STR in brave/brave-browser#8203

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

prevent generating duplicate tracking entries.
The cached ids are not accurate when receiving remote CREATE and then
committing UPDATE because we never get to propagate the real value to
other devices
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@LaurenWags
Copy link
Member

@btlechowski notes are here: brave/brave-browser#8203 (comment)

@LaurenWags notes:
Verified using

Brave 1.6.24 Chromium: 80.0.3987.100 (Official Build) nightly (64-bit)
Revision 3f00c26d457663a424865bbef1179f72eec1b9fe-refs/branch-heads/3987@{#864}
OS macOS Version 10.14.6 (Build 18G103)

Screen Shot 2020-02-13 at 12 40 25 PM

@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 consecutive sync updates will result deletion
4 participants