Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 8084: Decrease P3A upload interval. #4531

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Issue 8084: Decrease P3A upload interval. #4531

merged 1 commit into from
Feb 11, 2020

Conversation

iefremov
Copy link
Contributor

@iefremov iefremov commented Feb 6, 2020

Resolves brave/brave-browser#8084

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@iefremov iefremov self-assigned this Feb 6, 2020
iefremov pushed a commit that referenced this pull request Feb 6, 2020
@@ -43,7 +43,7 @@ constexpr char kLastRotationTimeStampPref[] = "p3a.last_rotation_timestamp";

constexpr char kDefaultUploadServerUrl[] = "https://p3a.brave.com/";

constexpr uint64_t kDefaultUploadIntervalSeconds = 60 * 60; // 1 hour.
constexpr uint64_t kDefaultUploadIntervalSeconds = 60; // 1 minute.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe we could do 1 * base::Time::kSecondsPerMinute so that it's clearer

Copy link
Contributor

@riastradh-brave riastradh-brave Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should transition all of the randomized delays from integral numbers of seconds to base::TimeDelta -- that's a more general issue that we should fix across the board.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riastradh-brave probably, base::TimeDelta, not base::Time? Is there an issue for this?

Copy link
Contributor

@riastradh-brave riastradh-brave Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Sorry, wires crossed -- base::time::kSecondsPerMinute is an integer number of seconds; using base::TimeDelta itself is a different issue. Don't mind me!)

Copy link
Contributor

@riastradh-brave riastradh-brave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iefremov
Copy link
Contributor Author

With the help of @linhkikuchi manually verified that CI is ok - only one unrelated build failure on mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce interval between P3A pings from ~1 hour to ~1 minute
4 participants